Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create "items" presentation component model #1178

Closed
oliverfoster opened this issue Jul 28, 2016 · 2 comments
Closed

Create "items" presentation component model #1178

oliverfoster opened this issue Jul 28, 2016 · 2 comments
Assignees
@tomgreenfield @oliverfoster @lc-thomasberger
Labels
enhancement question

Comments

@oliverfoster
Copy link
Member

oliverfoster commented Jul 28, 2016 •
edited
Loading

All of these components use the same model behaviour

Create a standard presentation component model for them
@tomgreenfield tomgreenfield mentioned this issue Jan 25, 2017
Closed
@oliverfoster
Copy link
Member Author

oliverfoster commented Feb 13, 2017 •
edited
Loading

any objection to me putting this in the core?

core/js/models/itemsModel.js

@moloko
Copy link
Contributor

moloko commented Feb 13, 2017

Could you also deal with #1365 at the same time?

@tomgreenfield tomgreenfield mentioned this issue Oct 25, 2017
Merged
@oliverfoster oliverfoster mentioned this issue Oct 25, 2017
Merged
@moloko moloko closed this as completed Jun 26, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tomgreenfield tomgreenfield

@oliverfoster oliverfoster

@lc-thomasberger lc-thomasberger

Labels
enhancement question
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@tomgreenfield @moloko @oliverfoster @lc-thomasberger