Add support for adapt_framework -> grunt server-build:dev #857

taylortom · 2015-09-22T11:00:16Z

Partial fix for #811

fixes #639

This was due to the default framework course folder being copied over to the temporary working/build directory. The fix is to remove it on installation.

Fixes #620

Adds ifUserIsMe and fixes inverse not being passed back

Fixes around CKEditor

Clarified NodeJS version.

Version 0.1.1.

Release/0.1.1

Add a Gitter chat badge to README.md

taylortom · 2015-09-22T11:09:45Z

Also see adaptlearning/adapt_framework#734

brian-learningpool · 2015-09-23T10:32:01Z

@taylortom, I really like this. Source maps would be of major help to developers trying to debug client-side code. The only thing I have issue with is using the isProduction config to toggle this. This config is already used in determine whether the web application should run in production mode.

Perhaps a new course setting would be more applicable?

taylortom · 2015-09-23T13:15:33Z

Fine by me - are you thinking another config.json option? (e.g. generateOutputSourcemap)

brian-learningpool · 2015-09-23T14:01:27Z

Yes, either in Configuration Settings or Project Settings.

The .match() call will fail if the url is empty.

Fixes #881 - bug in isAssetExternal()

Minor fixes

Develop

Also added a check that the current user was the user who created the course.

Hot-fixes for 0.1.3

taylortom · 2015-11-11T10:37:42Z

@brian-learningpool this work should be done now

taylortom · 2015-11-11T11:12:48Z

TODO: test this in older versions of the framework to make sure the params don't cause any unexpected problems if not used.

Also ran jscs to fix whitespace

…thoring into issue/811

brian-learningpool · 2015-11-23T12:21:09Z

@taylortom, this is really useful. I've just been testing this locally and I think there's one small thing it's missing though. When the _generateSourcemap value changes you you should trigger a flag to indicate that a full rebuild is required. Have a look at the rebuildCourse event:

 app.emit('rebuildCourse', tenantId, courseId);

dennis-learningpool · 2015-11-23T16:59:40Z

plugins/output/adapt/index.js

usually wary of trailing commas in a JS array like this - is it ok?

Think I ran the jscs grunt task at some point which may have added this.

…thoring into issue/811

This required both the config _id and the _courseId (in order to check permissions).

…tlearning/adapt_authoring into issue/811

taylortom · 2015-11-25T14:38:25Z

+1 for @brian-learningpool's changes

brian-learningpool · 2015-11-25T15:14:51Z

+1 for yours too! 👍

dennis-learningpool · 2015-11-25T15:46:41Z

+1 for everyone!

Add support for adapt_framework -> grunt server-build:dev

darylhedley and others added 14 commits April 15, 2015 15:47

Adds ifUserIsMe and fixes inverse not being passed back

c727bd7

fixes #639

Fixes #620

d850fc8

This was due to the default framework course folder being copied over to the temporary working/build directory. The fix is to remove it on installation.

Merge pull request #642 from adaptlearning/hotfix-620

9586a0b

Fixes #620

Merge pull request #641 from adaptlearning/issue/#639

35b2da8

Adds ifUserIsMe and fixes inverse not being passed back

Merge pull request #638 from adaptlearning/switch-ckeditor-to-cdn

526cf16

Fixes around CKEditor

Update README.md

de1f2f2

Clarified NodeJS version.

Merge branch 'develop'

ac5047a

Version 0.1.1.

Update version.json

783b7bc

Merge pull request #751 from adaptlearning/release/0.1.1

f61f9bf

Release/0.1.1

Update README.md

04b0c83

Added Gitter badge

4f37b42

Merge pull request #755 from gitter-badger/gitter-badge

78689d1

Add a Gitter chat badge to README.md

Add support for new server-build

1185118

Whitespace amends

53cf817

taylortom mentioned this pull request Sep 22, 2015

Add ability for server-build to generate source-maps adaptlearning/adapt_framework#734

Merged

brian-learningpool and others added 11 commits September 30, 2015 10:56

Merge branch 'develop'

9aa2d85

Update package.json

fe07051

Add source map toggle to config schema

fc3c5d8

Update adapt output plugin for sourcemapping

3ae042c

Fixes #881 - bug in isAssetExternal()

80d30cd

The .match() call will fail if the url is empty.

Merge pull request #882 from adaptlearning/issue/881

ff6cff9

Fixes #881 - bug in isAssetExternal()

Merge branch 'develop'

526ec3e

Update version.json

ce20d09

Merge pull request #902 from adaptlearning/develop

30a854c

Minor fixes

Merge pull request #904 from adaptlearning/develop

0cf5872

Develop

Renamed function to isMasterPreviewAccessible()

aba99d8

Also added a check that the current user was the user who created the course.

brian-learningpool added 2 commits October 22, 2015 14:35

Corrected z-index issue with asset-management-modal-tags

1f135b1

Merge pull request #915 from adaptlearning/develop

105b043

Hot-fixes for 0.1.3

taylortom and others added 2 commits November 18, 2015 10:56

Remove DB query for course config

43c4256

Also ran jscs to fix whitespace

Merge branch 'issue/811' of https://github.com/adaptlearning/adapt_au…

e43124c

…thoring into issue/811

dennis-learningpool reviewed Nov 23, 2015
View reviewed changes

taylortom and others added 6 commits November 24, 2015 12:48

Remove trailing comma

a962af2

Set config updates to PATCH

233b7c2

Merge branch 'issue/811' of https://github.com/adaptlearning/adapt_au…

23a7776

…thoring into issue/811

Define usermanager

a7871d1

Tidied up PATCH request for config update

d81ac64

This required both the config _id and the _courseId (in order to check permissions).

Merge branches 'issue/811' and 'issue/811' of https://github.com/adap…

f395520

…tlearning/adapt_authoring into issue/811

brian-learningpool added a commit that referenced this pull request Nov 25, 2015

Merge pull request #857 from adaptlearning/issue/811

951736f

Add support for adapt_framework -> grunt server-build:dev

brian-learningpool merged commit 951736f into develop Nov 25, 2015

brian-learningpool deleted the issue/811 branch November 25, 2015 15:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add support for adapt_framework -> grunt server-build:dev #857

Add support for adapt_framework -> grunt server-build:dev #857

taylortom commented Sep 22, 2015

taylortom commented Sep 22, 2015

brian-learningpool commented Sep 23, 2015

taylortom commented Sep 23, 2015

brian-learningpool commented Sep 23, 2015

taylortom commented Nov 11, 2015

taylortom commented Nov 11, 2015

brian-learningpool commented Nov 23, 2015

dennis-learningpool Nov 23, 2015

taylortom Nov 24, 2015

taylortom commented Nov 25, 2015

brian-learningpool commented Nov 25, 2015

dennis-learningpool commented Nov 25, 2015

Add support for adapt_framework -> grunt server-build:dev #857

Add support for adapt_framework -> grunt server-build:dev #857

Conversation

taylortom commented Sep 22, 2015

taylortom commented Sep 22, 2015

brian-learningpool commented Sep 23, 2015

taylortom commented Sep 23, 2015

brian-learningpool commented Sep 23, 2015

taylortom commented Nov 11, 2015

taylortom commented Nov 11, 2015

brian-learningpool commented Nov 23, 2015

dennis-learningpool Nov 23, 2015

Choose a reason for hiding this comment

taylortom Nov 24, 2015

Choose a reason for hiding this comment

taylortom commented Nov 25, 2015

brian-learningpool commented Nov 25, 2015

dennis-learningpool commented Nov 25, 2015