Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add background images to components #727

Closed
sandervanzijl opened this issue Jun 19, 2015 · 5 comments
Closed

Add background images to components #727

sandervanzijl opened this issue Jun 19, 2015 · 5 comments
Labels
D: hard Complex issues, require discussion and big time commitment

Comments

@sandervanzijl
Copy link

In the authoring tool, it would be really fantastic if it were to be possible to set a background image per page /article/block/component. This is now only possible by editing a theme. ideally the theme can be used over multple courses, so should not contain references to course specific images.

this way it would be possible, without any css coding, to use an image as the background for the course, then another image for the background of the article, and even images for the background of text etc.

off course some extra controls are needed such as setting transparency etc etc.

@brian-learningpool
Copy link
Member

This very feature is something which is in the roadmap for version 1.0.

@taylortom taylortom added the D: hard Complex issues, require discussion and big time commitment label Sep 8, 2015
@taylortom taylortom changed the title adding images to components Add background images to components Sep 28, 2015
@taylortom taylortom added this to the 0.?.0 Theme editor milestone Feb 9, 2017
@lc-thomasberger
Copy link
Member

I would not recommend to add background images directly to a page/article/block/component.

Instead themes should provide classes that apply images / colors to those elements.
The theme editor would then allow you to customize those classes by changing the color or by updating the image.

@sandervanzijl
Copy link
Author

if there is going to be a theme editor, then yes you could use the theme editor.
but in the opensource version there is no theme editor (sofar).

Also I do not agree that course specific images should be in a theme. A theme should be usable in many courses. Take for example a company developing multiple courses. They want to use the same theme for every course to create the same look and feel, but they also want to use images. So the theme just takes care of the basic look and feel of every course stuff, and the course specfic layout is done in the course itself.

an other option would be to have multiple themes. one general theme for all courses and one theme for the specific course. but this is a matter of implementation.

@taylortom
Copy link
Member

taylortom commented Mar 10, 2017

See theme editor prototype for ongoing work: #1499

@taylortom taylortom modified the milestones: 0.?.0 Theme/menu editor, 0.6.0 Scaffold rewrite Jun 5, 2018
@taylortom
Copy link
Member

This is fixed in #1116.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
D: hard Complex issues, require discussion and big time commitment
Projects
None yet
Development

No branches or pull requests

4 participants