Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabled previous/next button aria labels #310

Closed
swashbuck opened this issue Jul 12, 2024 · 1 comment · Fixed by #311
Closed

Disabled previous/next button aria labels #310

swashbuck opened this issue Jul 12, 2024 · 1 comment · Fixed by #311

Comments

@swashbuck
Copy link
Contributor

Subject of the issue

When at the beginning of a Narrative sequence / on the first slide, the Previous button's aria-label reads as:

Back to Narrative item 3 (item 3 of 3)

When on the last slide, the Next button's aria-label reads as:

Forward to Narrative item 1 (item 1 of 3), dimmed button

Since we do not have looping as a feature (as far as I know), I think these cases are both inaccurate.

Should the aria-labels be completely removed in these cases? Should they just be generic like Forward, dimmed button? To be clear, I'm only asking about when the user is on the first or last slide. No changes to the aria-labels in between.

@swashbuck swashbuck self-assigned this Aug 1, 2024
@swashbuck swashbuck moved this from New to Assigned in adapt_framework: The TODO Board Aug 1, 2024
@swashbuck swashbuck moved this from Assigned to Needs Reviewing in adapt_framework: The TODO Board Aug 1, 2024
@github-project-automation github-project-automation bot moved this from Needs Reviewing to Recently Released in adapt_framework: The TODO Board Aug 19, 2024
github-actions bot pushed a commit that referenced this issue Aug 19, 2024
## [7.10.1](v7.10.0...v7.10.1) (2024-08-19)

### Fix

* Change back and next button labels when at start / end (fixes #310) ([ad1b145](ad1b145)), closes [#310](#310)
Copy link

🎉 This issue has been resolved in version 7.10.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
1 participant