Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Moved breakpoint to medium from large #169

Merged
merged 2 commits into from
May 12, 2023
Merged

Fix: Moved breakpoint to medium from large #169

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
29a8497
Fix: Moved breakpoint to medium from large
oliverfoster May 10, 2023
649cb22
fw 5.31.2
oliverfoster May 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "adapt-contrib-gmcq",
"version": "7.3.8",
"framework": ">=5.19.1",
"framework": ">=5.31.2",
"homepage": "https://github.com/adaptlearning/adapt-contrib-gmcq",
"bugs": "https://github.com/adaptlearning/adapt-contrib-gmcq/issues",
"component": "gmcq",
Expand Down
6 changes: 3 additions & 3 deletions templates/gmcq.jsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,7 @@ export default function Gmcq(props) {
onItemBlur
} = props;

const screenSize = device.screenSize;
const hasColumnLayout = device.isScreenSizeMin('medium');

return (
<div className='component__inner gmcq__inner'>
Expand All @@ -40,7 +40,7 @@ export default function Gmcq(props) {
!_isEnabled && 'is-disabled',
_isInteractionComplete && 'is-complete is-submitted show-user-answer',
_isCorrect && 'is-correct',
_columns && screenSize === 'large' && 'has-column-layout'
_columns && hasColumnLayout && 'has-column-layout'
])}
role={_isRadio ? 'radiogroup' : 'group'}
aria-labelledby={ariaQuestion ? null : (displayTitle || body || instruction) && `${_id}-header`}
Expand All @@ -55,7 +55,7 @@ export default function Gmcq(props) {
(_shouldShowMarking && _shouldBeSelected) ? 'is-correct' : null,
(_shouldShowMarking && !_shouldBeSelected) ? 'is-incorrect' : null
])}
style={(_columns && screenSize === 'large') ?
style={(_columns && hasColumnLayout) ?
{ width: `${100 / _columns}%` } :
null}
key={_index}
Expand Down