Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update: alternative item option text added (fixes #172) #173

Merged
merged 6 commits into from
Oct 26, 2023
Merged

Update: alternative item option text added (fixes #172) #173

merged 6 commits into from
Oct 26, 2023

Conversation

kirsty-hames
Copy link
Contributor

@kirsty-hames kirsty-hames commented Oct 25, 2023 •
edited
Loading

Fixes #172

Provide an optional altText property to set the item aria-label. If no altText is set, then text will set the aria-label as per the current functionality.

Use altText to specify how a word or words should be pronounced.

e.g. 'IT' to read as 'eye tea' not 'it'.

e.g '$5bn' to read as 'five billion dollars' not 'dollar symbol five b n'.

See similar PR for MCQ adaptlearning/adapt-contrib-mcq#210

@kirsty-hames kirsty-hames self-assigned this Oct 25, 2023
@kirsty-hames kirsty-hames mentioned this pull request Oct 25, 2023
Merged
joe-allen-89
joe-allen-89 approved these changes Oct 25, 2023
View reviewed changes
Copy link
Contributor

@joe-allen-89 joe-allen-89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

oliverfoster
oliverfoster reviewed Oct 26, 2023
View reviewed changes
templates/gmcq.jsx Outdated Show resolved Hide resolved
@kirsty-hames @oliverfoster
Normalise altText
7a56375 
Co-authored-by: Oliver Foster <[email protected]>
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Oct 26, 2023
View reviewed changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@joe-allen-89 joe-allen-89 merged commit 5102451 into master Oct 26, 2023
@joe-allen-89 joe-allen-89 deleted the issue/172 branch October 26, 2023 09:02
github-actions bot pushed a commit that referenced this pull request Oct 26, 2023
@semantic-release-bot
Chore(release): 7.4.0 [skip ci]
27f2424 
# [7.4.0](v7.3.10...v7.4.0) (2023-10-26)

### Update

* alternative item option text added (fixes #172)  (#173) ([5102451](5102451)), closes [#172](#172) [#173](#173)
@github-actions
Copy link

🎉 This PR is included in version 7.4.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@oliverfoster oliverfoster oliverfoster approved these changes

Assignees

@kirsty-hames kirsty-hames

Labels
accessibility released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Item option text doesn't support an accessible alternative
4 participants
@kirsty-hames @oliverfoster @cahirodoherty-learningpool @joe-allen-89