Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Button aria contains text not accessible for translations (fixes #151) #156

Merged
merged 2 commits into from
Jun 26, 2023
Merged

Fix: Button aria contains text not accessible for translations (fixes #151) #156

merged 2 commits into from
Jun 26, 2023

Conversation

swashbuck
Copy link
Contributor

@swashbuck swashbuck commented Jun 23, 2023 •
edited
Loading

Fixes #151

Fix

  • Adds new property itemCount with a default value of Item {{_nthChild}} of {{_totalChild}}
  • Adjustments to space characters in button aria-label so that it doesn't start with a space.

@swashbuck swashbuck self-assigned this Jun 23, 2023
@swashbuck swashbuck marked this pull request as ready for review June 23, 2023 18:00
cahirodoherty-learningpool
cahirodoherty-learningpool approved these changes Jun 26, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👀

@kirsty-hames kirsty-hames merged commit a60e6da into master Jun 26, 2023
@kirsty-hames kirsty-hames deleted the issue/151 branch June 26, 2023 13:12
github-actions bot pushed a commit that referenced this pull request Jun 26, 2023
@semantic-release-bot
Chore(release): 6.3.10 [skip ci]
8b88742 
## [6.3.10](v6.3.9...v6.3.10) (2023-06-26)

### Fix

* Button aria contains text not accessible for translations (fixes #151) (#156) ([a60e6da](a60e6da)), closes [#151](#151) [#156](#156)
@github-actions
Copy link

🎉 This PR is included in version 6.3.10 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@swashbuck swashbuck mentioned this pull request Jul 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joe-allen-89 joe-allen-89 joe-allen-89 approved these changes

@eleanor-heath eleanor-heath eleanor-heath approved these changes

@cahirodoherty-learningpool cahirodoherty-learningpool cahirodoherty-learningpool approved these changes

@kirsty-hames kirsty-hames kirsty-hames approved these changes

@oliverfoster oliverfoster Awaiting requested review from oliverfoster

Assignees

@swashbuck swashbuck

Labels
accessibility bug released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

button aria contains text not accessible for translations
5 participants
@swashbuck @kirsty-hames @cahirodoherty-learningpool @eleanor-heath @joe-allen-89