From 564f41aa1d823a64802a20b71611e0be711e1082 Mon Sep 17 00:00:00 2001 From: Stuart Date: Tue, 23 May 2023 19:00:25 +0100 Subject: [PATCH] Fix: added schema for xlarge (#154) --- properties.schema | 36 ++++++++++++++++++++++++++++++------ schema/course.schema.json | 38 ++++++++++++++++++++++++++++++++------ 2 files changed, 62 insertions(+), 12 deletions(-) diff --git a/properties.schema b/properties.schema index b485b77..1245630 100644 --- a/properties.schema +++ b/properties.schema @@ -58,13 +58,21 @@ "required": false, "legend": "Menu background image", "properties": { + "_xlarge": { + "type": "string", + "required": false, + "default": "", + "inputType": "Asset:image", + "validators": [], + "help": "Extra large background image, e.g. hd laptop/desktop computers" + }, "_large": { "type": "string", "required": false, "default": "", "inputType": "Asset:image", "validators": [], - "help": "Large background image - used on desktop" + "help": "Large background image, e.g. laptop/desktop computers" }, "_medium": { "type": "string", @@ -72,7 +80,7 @@ "default": "", "inputType": "Asset:image", "validators": [], - "help": "Medium background image - used on tablet" + "help": "Medium background image, e.g. tablet devices" }, "_small": { "type": "string", @@ -80,7 +88,7 @@ "default": "", "inputType": "Asset:image", "validators": [], - "help": "Small background image - used on mobile" + "help": "Small background image, e.g. mobile / cellphones" } } }, @@ -155,13 +163,21 @@ "required": false, "legend": "Menu header background image", "properties": { + "_xlarge": { + "type": "string", + "required": false, + "default": "", + "inputType": "Asset:image", + "validators": [], + "help": "Extra large background image, e.g. hd laptop/desktop computers" + }, "_large": { "type": "string", "required": false, "default": "", "inputType": "Asset:image", "validators": [], - "help": "Large background image - used on desktop" + "help": "Large background image, e.g. laptop/desktop computers" }, "_medium": { "type": "string", @@ -169,7 +185,7 @@ "default": "", "inputType": "Asset:image", "validators": [], - "help": "Medium background image - used on tablet" + "help": "Medium background image, e.g. tablet devices" }, "_small": { "type": "string", @@ -177,7 +193,7 @@ "default": "", "inputType": "Asset:image", "validators": [], - "help": "Small background image - used on mobile" + "help": "Small background image, e.g. mobile / cellphones" } } }, @@ -217,6 +233,14 @@ "required": false, "legend": "Menu header minimum height", "properties": { + "_xlarge": { + "type": "number", + "required": false, + "default": "", + "inputType": "Number", + "validators": ["number"], + "help": "Minimum height should only be used in instances where the menu header height needs to be greater than the content e.g. to prevent a background image being cropped" + }, "_large": { "type": "number", "required": false, diff --git a/schema/course.schema.json b/schema/course.schema.json index 0728c9d..0da6863 100644 --- a/schema/course.schema.json +++ b/schema/course.schema.json @@ -71,11 +71,21 @@ "title": "Background image", "default": {}, "properties": { + "_xlarge": { + "type": "string", + "isObjectId": true, + "title": "Extra large", + "description": "Extra large background image, e.g. hd laptop/desktop computers", + "_backboneForms": { + "type": "Asset", + "media": "image" + } + }, "_large": { "type": "string", "isObjectId": true, "title": "Large", - "description": "Large background image - used on desktop", + "description": "Large background image, e.g. laptop/desktop computers", "_backboneForms": { "type": "Asset", "media": "image" @@ -85,7 +95,7 @@ "type": "string", "isObjectId": true, "title": "Medium", - "description": "Medium background image - used on tablet", + "description": "Medium background image, e.g. tablet devices", "_backboneForms": { "type": "Asset", "media": "image" @@ -95,7 +105,7 @@ "type": "string", "isObjectId": true, "title": "Small", - "description": "Small background image - used on mobile", + "description": "Small background image, e.g. mobile / cellphones", "_backboneForms": { "type": "Asset", "media": "image" @@ -212,11 +222,21 @@ "title": "Header background image", "default": {}, "properties": { + "_xlarge": { + "type": "string", + "isObjectId": true, + "title": "Extra large", + "description": "Extra large background image, e.g. hd laptop/desktop computers", + "_backboneForms": { + "type": "Asset", + "media": "image" + } + }, "_large": { "type": "string", "isObjectId": true, "title": "Large", - "description": "Large background image - used on desktop", + "description": "Large background image, e.g. laptop/desktop computers", "_backboneForms": { "type": "Asset", "media": "image" @@ -226,7 +246,7 @@ "type": "string", "isObjectId": true, "title": "Medium", - "description": "Medium background image - used on tablet", + "description": "Medium background image, e.g. tablet devices", "_backboneForms": { "type": "Asset", "media": "image" @@ -236,7 +256,7 @@ "type": "string", "isObjectId": true, "title": "Small", - "description": "Small background image - used on mobile", + "description": "Small background image, e.g. mobile / cellphones", "_backboneForms": { "type": "Asset", "media": "image" @@ -302,6 +322,12 @@ "title": "Header minimum height", "default": {}, "properties": { + "_xlarge": { + "type": "number", + "title": "Extra Large", + "description": "Minimum height should only be used in instances where the menu header height needs to be greater than the content e.g. to prevent a background image being cropped", + "default": 0 + }, "_large": { "type": "number", "title": "Large",