Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignoring .pyd files in data/ directory #43

Open
sharm294 opened this issue Feb 13, 2024 · 1 comment
Open

Ignoring .pyd files in data/ directory #43

sharm294 opened this issue Feb 13, 2024 · 1 comment

Comments

@sharm294
Copy link

Hi,

I saw this commit changed the behavior to ignore .pyd files in the data directory outside of two specific directories. Could you elaborate on why this change was made?

Also, would you have any insight on how to export a package out of CMake that would place the .pyd files in the structure expected by delvewheel? Right now, I'm using the release prior to the above change and the .pyd files get exported relative to data/. I set the LIBRARY DESTINATION for the install() to lib/site-packages/<name>.libs so they get extracted to the same directory as the dependent DLLs that delvewheel adds into the wheel when it finds the .pyd files.

@adang1345
Copy link
Owner

The .data directory supports 5 subdirectories: purelib, platlib, headers, scripts, and data. I am aware of use cases where .pyd files are placed in purelib and platlib, but I am not aware of use cases for putting .pyd files in the other 3 subdirectories. My understanding is that the data subdirectory is typically used for data files rather than Python code files, which is why I made the change to ignore it.

I am not familiar with CMake, so I can't help with that aspect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants