Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments removed when formatting #9

Open
krazik opened this issue Aug 3, 2017 · 8 comments
Open

Comments removed when formatting #9

krazik opened this issue Aug 3, 2017 · 8 comments

Comments

@krazik
Copy link

krazik commented Aug 3, 2017

I can't figure out how to stop it but this plugin removes all comments # Foo from my yaml files.

@adamvoss
Copy link
Owner

adamvoss commented Aug 3, 2017

I recognize this is not an ideal solution, but the solution is to not use the code formatting functionality.

The underlying library that provides formatting does not (and will not) support comments. If another workable library can be found that preserves comments, I would be happy to switch.

@krazik
Copy link
Author

krazik commented Aug 5, 2017

yeah that sucks I obviously understand too. thanks for the reply.

-Ry

@adamvoss
Copy link
Owner

Reopening as a placeholder to try to reduce issue duplication.

@adamvoss adamvoss reopened this Aug 24, 2017
@adamvoss adamvoss changed the title Removal of comments Comments removed when formatting Aug 24, 2017
@txomon
Copy link

txomon commented Oct 8, 2017

Would you mind listing this in Known Issues section? Thanks!

@adamvoss
Copy link
Owner

@txomon That is a good idea. It will require a new release of vscode-yaml in order to show on the marketplace and I'm currently working on some potentially big changes regarding this extension, so I might let some of that hash out in the next couple days first.

@ecstasy2
Copy link

+1
This is a deal breaker for me. Yaml is code and code need documentation. It would be nice if we can find a alternative.

@fullc0ntr0l
Copy link

@BYK
Copy link

BYK commented Jul 19, 2019

@adamvoss is there any possibility to replace the parser witn yawn-yaml as @fullc0ntr0l suggested? I can open a PR if you are okay with the idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants