You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The underlying parser (yaml-ast-parser) treats unrecognized custom tags as errors. (relevant code)
Currently, there is no way to pass custom tags into yaml-ast-parser, since it's being used to generate a generic AST for later validation by VSCode's language tooling. (relevant code)
It may be more appropriate to modify yaml-ast-parser to accept a flag which disables custom tag type validation (you seem to be a contributor there as well), or perhaps this plugin can call the parser with options (such as typeMap) taken from the VSCode settings entry for the active schema.
The text was updated successfully, but these errors were encountered:
Thanks for investigating this @tvald! I have no special relationship to yaml-ast-parser but I have had good success with that project accepting pull requests.
You probably have a better idea than I regarding which would be more desired/convenient/practical: the global opt-out or opt-in of each custom tag. Which would you want?
Either change you mentioned doesn't sound too complicated. Is this something you would be interested in working on?
The only outstanding complication I can think of would be deciding how these custom tag nodes should be represented in the VSCode AST (which also directs how JSON Schema validation would behave around them).
The underlying parser (
yaml-ast-parser
) treats unrecognized custom tags as errors. (relevant code)Currently, there is no way to pass custom tags into
yaml-ast-parser
, since it's being used to generate a generic AST for later validation by VSCode's language tooling. (relevant code)It may be more appropriate to modify
yaml-ast-parser
to accept a flag which disables custom tag type validation (you seem to be a contributor there as well), or perhaps this plugin can call the parser with options (such astypeMap
) taken from the VSCode settings entry for the active schema.The text was updated successfully, but these errors were encountered: