Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass/Fail filters #5

Closed
scott2449 opened this issue Feb 26, 2015 · 3 comments
Closed

Pass/Fail filters #5

scott2449 opened this issue Feb 26, 2015 · 3 comments
Milestone

Comments

@scott2449
Copy link
Contributor

It looks like the JS code allows for filters to stack or some such nonsense 😈

  1. If I click on fail number and that removes all the tests, and then I click on success which shows me 50% of the tests. If keep clicking on success it toggles between 50% and 0% instead of 50% and 100% which is what I would expect.

  2. A visual indication of what filters are in play would also be awesome.

@adamgruber adamgruber added this to the The Future milestone Feb 27, 2015
@adamgruber
Copy link
Owner

  1. This is the expected behavior. The filters turn on/off the display of those tests. Click 'Passing' it will show you all passing tests. Click 'Failed' and it will show failed tests, in addition to the passing tests that were already showing. Think of the filters as checkboxes and not a radio button group. We could argue which functionality is more 'expected' but it is by no means broken in its current state. It works as intended.
  2. There are multiple visual indicators as to what filter(s) are active. In the main summary, an active filter will have bold colored text.The active filters are also underlined in each test summary. I'll concede that these indicators may be too subtle. I can look at enhancing them in a future update.

@scott2449
Copy link
Contributor Author

:rage1: 🐄 💩

😪

@scott2449
Copy link
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants