Max migration file computes incorrect max-migration, in case earlier migrations before installing the library have custom names, not starting with numbers.

[shikhart98]

Python Version

3.8

Django Version

2.2.5

Package Version

2.3.0

Description

Max migration file computes incorrect max-migration, in case earlier migrations before installing the library have custom names, not starting with numbers.

Example:

• app
  • migrations
    | - 001.py
    | - 002.py
    | - custom_migration_name.py
    | - 003.py

in above migration folder actual dependency chain is: 001 -> 002 -> custom_migration_name -> 003

But when I am generating max migration file here I am getting custom_migration_name value over there, when my actual latest migration is 003.

[adamchainz]

Please provide an example rather than a one line description.

[shikhart98]

@adamchainz Updated the description.

[adamchainz]

Is this when you use create_max_migration_files, or later when you use makemigrations?

[shikhart98]

When I use create_max_migration_files.

[shikhart98]

@adamchainz any update on this?

[adamchainz]

Currently we use max(migration_details.names) in a couple places to find the latest migration. I guess to be strictly correct, we need to change to using Django's MigrationLoader class to build the migration graph, when we can detect the final migration. This would also let us detect conflicts where there are multiple leaf migrations, like migrate does, by calling the loader's detect_conflicts() method.