Skip to content
This repository has been archived by the owner on Dec 3, 2021. It is now read-only.

Wish: Add "x-www-form-urlencoded" body support. #36

Open
nduijvelshoff opened this issue Nov 23, 2018 · 1 comment
Open

Wish: Add "x-www-form-urlencoded" body support. #36

nduijvelshoff opened this issue Nov 23, 2018 · 1 comment

Comments

@nduijvelshoff
Copy link

Hi There,

Since I'm using Azure AD as my OAuth2 IdP, I get the error that all mandatory fields are missing at the "../oauth2/token" endpoint. I figured, that this is due to the fact that react-oauth-flow sends the fields as query parameters. To make it work with azure I would like to ask for the support of "x-www-form-urlencoded" body parameters in an addition to the current possibility.

Regards,

Nick

@adambrgmn
Copy link
Owner

Hi sorry for the long break here.
Unfortunately as popularity of this library grew I have understood that all OAuth implementations doesn't look the same and the requirements are very differentiated.

I would love to find some great middleway with good defaults and the ability to customize it to fit everyones needs. But I have yet to come up with a great solution. Maybe you have some ideas?

And also, I feel the implementation is pretty straight forward and that running your own fork inside your project might be easier and would probably mean less overhead in terms of code size.

But I will take another look at how to change this library into something more usable.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants