Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adabot submodule needs to be fixed and repinned #1091

Closed
tekktrik opened this issue Nov 7, 2022 · 6 comments · Fixed by #1092
Closed

Adabot submodule needs to be fixed and repinned #1091

tekktrik opened this issue Nov 7, 2022 · 6 comments · Fixed by #1092
Assignees
Labels
bug Something isn't working

Comments

@tekktrik
Copy link
Member

tekktrik commented Nov 7, 2022

The cron the updates the contributing information is failing because Adabot's current method of using validators is failing for Python 3.11. I've submitted adafruit/adabot#309 for this - hopefully that's the only change needed. After that's merged, the adabot submodule should be updated here.

@tekktrik tekktrik added the bug Something isn't working label Nov 7, 2022
@tekktrik tekktrik self-assigned this Nov 7, 2022
@tekktrik
Copy link
Member Author

tekktrik commented Nov 7, 2022

Looks like this wasn't enough - I think it may be worth pinning the Python version similar to the way Adabot does to Python 3.9. If so, should it be penultimate (3.10) or the same as Adabot (3.9)?

@tekktrik tekktrik reopened this Nov 7, 2022
@makermelissa
Copy link
Collaborator

@tekktrik
Copy link
Member Author

tekktrik commented Nov 7, 2022

Yup! For reference, the BigQuery package adabot now needs isn't avialable for Python 3.11 yet.

@tekktrik
Copy link
Member Author

tekktrik commented Nov 7, 2022

Linking googleapis/python-bigquery#1386 so we can track it potentially

@makermelissa
Copy link
Collaborator

I see there were a couple of related PRs. Is this fixed now?

@tekktrik
Copy link
Member Author

tekktrik commented Nov 9, 2022

Yup! Thanks for catching!

@tekktrik tekktrik closed this as completed Nov 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants