Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenarios can be marked as ignored by prefixing them with 'Pending' #24

Closed
wants to merge 1 commit into from

Conversation

akikhtenko
Copy link
Contributor

This pull request allows (as least for us) to do proper ATDD. I.e. define a scenario first, see it failing then do incremental changes to the production code until the scenario becomes green. So a scenario can remain in the 'pending' state and be merged to master without breaking CI builds.

There're other possible applications of the 'pending' scenario annotation.

You may find the TextParser refactoring quite intrusive - I don't mind if you throw it away and replace it with old (not very elegant) switch statement.

The change should be transparent for the existing library clients.

@akikhtenko
Copy link
Contributor Author

Sure, no worries. Think a more generic annotation handling is a great idea.
Closing the PR for now.

@akikhtenko akikhtenko closed this Sep 29, 2013
@cressie176
Copy link
Member

Support for Pending annotations is in 0.6.2

On 28 September 2013 19:52, akikhtenko [email protected] wrote:

This pull request allows (as least for us) to do proper ATDD. I.e. define
a scenario first, see it failing then do incremental changes to the
production code until the scenario becomes green. So a scenario can remain
in the 'pending' state and be merged to master without breaking CI builds.

There're other possible applications of the 'pending' scenario annotation.

You may find the TextParser refactoring quite intrusive - I don't mind if
you throw it away and replace it with old (not very elegant) switch
statement.

The change should be transparent for the existing library clients.

You can merge this Pull Request by running

git pull https://github.com/akikhtenko/yadda pending-scenarios

Or view, comment on, or merge it at:

#24
Commit Summary

  • Scenarios can be marked as ignored by prefixing them with 'Pending'

File Changes

Patch Links:

http://peaceoneday.org/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants