Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating amqplib dependency #52

Closed
cjmaria opened this issue Apr 10, 2021 · 3 comments · Fixed by #73
Closed

Updating amqplib dependency #52

cjmaria opened this issue Apr 10, 2021 · 3 comments · Fixed by #73

Comments

@cjmaria
Copy link

cjmaria commented Apr 10, 2021

Hello, I am using celery.node in an application built with the latest version of node.js. Whenever I run npm install, I get warnings related to ampqlib having an unsupported node version:

npm WARN EBADENGINE Unsupported engine {
npm WARN EBADENGINE   package: '[email protected]',
npm WARN EBADENGINE   required: { node: '>=0.8 <=12' },
npm WARN EBADENGINE   current: { node: 'v15.11.0', npm: '7.6.0' }
npm WARN EBADENGINE }

This can be resolved by updating celery.node to use the latest version of ampqlib which supports newer node.js versions. Is there any reason why you use ampqlib 0.5.6?

@actumn
Copy link
Owner

actumn commented Apr 10, 2021

Hi, cjmaria!
Thank you for reporting the issue.

There's no special reason that celery.node uses the specific version.
It was just the latest version when I created it.

It would be greatly appreciated if you make a pull request to bump it.

@daffron
Copy link
Contributor

daffron commented May 10, 2021

Hey,

Im going to submit a PR which just includes an update of this dependency - as it is throwing a high importance vulnerability warning.

Thanks

@actumn
Copy link
Owner

actumn commented May 11, 2021

@daffron Thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants