[Managed Markets] Adding new payment icon for KCP Credit Card and updating Vipps payment icon

[mseal-shopify]

This closes: https://github.com/Shopify/markets-pro-payments/issues/1899

Why are you adding this icons?

I'm adding a new payment icon for KCP. I used the SVGO UI to optimise the icon. https://checkoutshopper-live.adyen.com/checkoutshopper/images/logos/kcp_creditcard.svg

I'm also updating Vipps icon to latest icon. https://checkoutshopperlive.adyen.com/checkoutshopper/images/logos/vipps.svg

Checklist to add new icons

• All icons have a corresponding entry in db/payment_icons.yml
• I have followed the icon guidelines detailed in the CONTRIBUTING.md file
• I have optimized the icon with SVGO
• I am confident that all icons are clear and easy to read/understand
• I have provided a link to the brand icon’s brand guidelines whenever possible.

[Lydia-shan-git]

Make sure the entire logo fits within the borders. Currently, you have a green square that overlaps on top of the border by a smidge. Other than everything else looks good

[Lydia-shan-git]

Looking good! Just run it through SVGO so it's the smallest possible file size

[adeniyiao]

Hi @mseal-shopify , just a quick observation, for kcp_creditcard, the icon name and filename should be lowercase alpha characters only as per the guide.

Thanks

[mseal-shopify]

Hi @mseal-shopify , just a quick observation, for kcp_creditcard, the icon name and filename should be lowercase alpha characters only as per the guide.

Thanks

Thanks pointing that out, but I see there are other icons as well with underscore in their names. Is that something that's not allowed?

[adeniyiao]

Hi @mseal-shopify , sorry for the late response. Previously underscore was accepted for the old icons, but new icons should not have underscore as per latest guide.