remove trailing comma from commands #263
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ericsciple
commented
Dec 17, 2019
| import * as command from '../src/command' | ||
| import * as os from 'os' | ||
|
|
||
| /* eslint-disable @typescript-eslint/unbound-method */ |
There was a problem hiding this comment.
this is so beforeAll can reference originalWriteFunction. note, core.test.ts does a similar thing so there was a precedent for disabling this already
TingluoHuang
approved these changes
Dec 18, 2019
| @@ -37,21 +37,21 @@ describe('@actions/core', () => { | |||
|
|
|||
| it('exportVariable produces the correct command and sets the env', () => { | |||
| core.exportVariable('my var', 'var val') | |||
| assertWriteCalls([`::set-env name=my var,::var val${os.EOL}`]) | |||
| assertWriteCalls([`::set-env name=my var::var val${os.EOL}`]) | |||
There was a problem hiding this comment.
maybe I missed it but do we have any tests that validate multiple properties (and thus does write the comma)?
There was a problem hiding this comment.
yep command.test.ts is new and tests several combinations
This was referenced Mar 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #208