-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(cache): change key to match actions/cache documentation #323
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Matthieu MOREL <[email protected]>
it's a lot faster to start from a 90% correct cache than an empty one re: actions#286 re: actions#323 re: actions#328
Does it make sense to fallback on a shared prefix without the package manager? They probably even use different cache directories. |
I would agree, falling back to a prefix without package manager probably isn't useful — they definitely use separate cache paths. |
Hey just saw a link to this PR. I'd like to mention few discoveries I did recently
You can see two examples based on
It might be helpful. |
I believe this is only true if you're not using the global cache in your project. From |
True, if you look at the yarn gist you'll see that on ci the global cache is disabled YARN_ENABLE_GLOBAL_CACHE=false through an env. That makes it work independently of config. |
I see. For the record, I would hate it if the node action overrode my yarn config 😄 |
Added an up to date evolution of this PR over here: #702
That PR fixes this ☝️
And it also fixes the infinitely growing cache problem that comes with this ☝️ |
it's a lot faster to start from a 90% correct cache than an empty one re: actions#286 re: actions#323 re: actions#328
Bumps [@vercel/ncc](https://github.com/vercel/ncc) from 0.31.1 to 0.32.0. - [Release notes](https://github.com/vercel/ncc/releases) - [Commits](vercel/ncc@0.31.1...0.32.0) --- updated-dependencies: - dependency-name: "@vercel/ncc" dependency-type: direct:development update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
This PR change the cache key construction to fit those examples. It also add the use of restoreKeys and a more verbose log when retrieving fails.