-
Notifications
You must be signed in to change notification settings - Fork 746
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for GraalVM #195
Comments
@morki , have you tried the community action for GraalVM? |
Yes, but with this action we can use matrix builds for many JDKs and soon it will hopefully be support for Gradle / Maven caching here. |
Just for the record, here is a link to yet another |
Although official setup-graalvm action definitely would handle graal-specific extensions better, is someone interested in |
I am also very interested in seeing setup-java provide graalvm support, so it can be used in matrix builds to easily test it against other JDK providers. @zharinov is willing to provide a PR implementing this, but wants a signal from the maintainers (e.g. @dmitry-shibanov @IvanZosimov @marko-zivic-93) of this repo that there actually is interest in such a contribution. can one of you guys please confirm this? thanks a lot in advance! |
Hi, @sebthom 👋 Thanks for the comment! We are currently investigating the license of the GraalVM JDK. As soon as we finish this process we will get back to you with additional information. |
Hi, @ALL 👋 Unfortunately, during the investigation it was decided not to add support of GraalVM to setup-java action. The reason for this decision is existence of the official GraalVM action: https://github.com/marketplace/actions/github-action-for-graalvm |
@IvanZosimov That is more than disappointing. The problem is, that even if this action is available it does not solve the usecase of matrix builds with different JDK vendors when GraalVM should be included. This decision is also incomprehensible because someone from the community (@zharinov) even offers to implement it. |
this seems like a pretty powerful argument |
Hi, @sebthom and @SethTisue , thanks for the comments. You can use the above-mentioned action in a separate job, it will have the same effect as the additional member of matrix. |
@IvanZosimov That approach totally goes against the DRY principle. There is a reason why GitHub Action provides matrix builds. I find this reasoning not comprehensible. Based on your argumentation, there is also no reason that setup-java supports installation of Oracle JDK as there is the setup-java-development-kits-built-by-oracle action. |
I agree with @sebthom, if @IvanZosimov's argument is true, CI's won't exist since there is already actions in GitHub(i.e. GitHub Actions). Still why CI's exist? |
Looks like this has actually been implemented by #501 in the meantime |
Description:
It would be nice to support GraalVM Community Edition JDK.
Justification:
It is already available in Github Actions virtual environments.
Are you willing to submit a PR?
Sorry but no, I don't have enought knowledge.
The text was updated successfully, but these errors were encountered: