Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Broken version normalization #35

Closed
tie opened this issue Dec 18, 2019 · 3 comments
Closed

Broken version normalization #35

tie opened this issue Dec 18, 2019 · 3 comments
Assignees
@bryanmacfarlane

Comments

@tie
Copy link

tie commented Dec 18, 2019 •
edited
Loading

PR #13 broke the way version normalization works. Since it’s merged, now 1.10 resolves to 1.10.8 or whatever the latest version is instead of 1.10.0. This is not the behavior Go user expects.
@tie tie changed the title Broken version resolution Broken version normalization Dec 18, 2019
@tie
Copy link
Author

tie commented Dec 18, 2019

See golang/go#32450

@tie tie mentioned this issue Dec 18, 2019
Closed
@bryanmacfarlane bryanmacfarlane self-assigned this Feb 7, 2020
@bryanmacfarlane
Copy link
Member

The version input is a semver spec (not a version input). So it accepts things like ^1.10.6, ranges etc.

Since it's a semver spec, 1.10 does satisfy 1.10.8 ... https://jubianchi.github.io/semver-check/#/1.10/1.10.8

If you want 1.10.0, then supply the semver spec 1.10.0

@bryanmacfarlane
Copy link
Member

Closing based on ☝️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bryanmacfarlane bryanmacfarlane

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add support for gotip and latest
2 participants
@bryanmacfarlane @tie