Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

V2 not working with GHES 3.7 #168

Closed
FloThinksPi opened this issue May 4, 2023 · 5 comments · Fixed by #173
Closed

V2 not working with GHES 3.7 #168

FloThinksPi opened this issue May 4, 2023 · 5 comments · Fixed by #173
Assignees
Labels
documentation Improvements or additions to documentation GHES Specific to GitHub Enterprise Server

Comments

@FloThinksPi
Copy link

FloThinksPi commented May 4, 2023

Apearently V2 of this action is incompatible with GHES3.7

Error: Creating Pages deployment failed
Error: HttpError: Not Found
    at /__w/_actions/actions/deploy-pages/v2/webpack:/deploy-pages/node_modules/@octokit/request/dist-node/index.js:86:1
    at processTicksAndRejections (node:internal/process/task_queues:96:5)
    at createPagesDeployment (/__w/_actions/actions/deploy-pages/v2/webpack:/deploy-pages/src/internal/api-client.js:116:1)
    at Deployment.create (/__w/_actions/actions/deploy-pages/v2/webpack:/deploy-pages/src/internal/deployment.js:58:1)
    at main (/__w/_actions/actions/deploy-pages/v2/webpack:/deploy-pages/src/index.js:30:1)
Error: Error: Failed to create deployment (status: 404) with build version cb8ac69b6379743b17029f637df101077fc70698. Ensure GitHub Pages has been enabled: https://github.enterprise.server/org/repo/settings/pages

In the release note i did not find any hint on this and also no documentation starting with what GHES version the V2 version of this action can be used. Could someone briefly add starting with which GHES version the V2 of this action is supposed to work ?

@jtietema
Copy link

jtietema commented May 5, 2023

We are currently facing a the same error on GHES 3.8.2, the v1 stopped working as well. I wonder if this was a GHES change that broke it, as I can't find a combination of old versions that work either....

@jkmgbrt
Copy link

jkmgbrt commented May 10, 2023

Perhaps v2 is not compatible since the deployment API endpoints seems to have been changed in v2 to endpoints not corresponding with the ones described in the GHES 3.8 docs (hence the status: 404 response)?

v1...v2
b254707

@FloThinksPi
Copy link
Author

FloThinksPi commented May 12, 2023

@jtietema Yea defenetely not supported for GHES 3.7 and 3.8. Since the action supports GHES in general i am just missing information (docs) here beginning with what GHES version V2 of this action is supported. I suppose things will also stop working on a GHES update(that changes the used api endpoint that also reflect the difference between v1 and v2 of this action) when running V1 of this action and then every workflow needs to change to V2 ? Maybe there is some information to share on this too ? Reading just the api docs of GHES i am not that sure to make the correct assumption when to use V1 and V2 since i am not that much into the actions actual logic.

@JamesMGreene
Copy link
Contributor

You are correct that v2 of this action will not work with any of the currently released GHES versions.

As far as we know, however, every version of this action under the v1 series, including the latest v1, should work successfully for GHES with the specific EXCEPTION of:

Could you please attempt to use one of those v1/v1.x.x versions instead? Let us know if you're still running into issues. Thank you, and apologies for the confusion! 🙇🏻

@JamesMGreene
Copy link
Contributor

I've added a compatibility table into the README and a note about it into future release notes:

If you're still struggling to get this action working with GHES when using the v1 series, please feel free to reopen this issue or create a new one. Thanks for helping us expand our understanding of how GHES users are consuming our actions! 🙇🏻

@JamesMGreene JamesMGreene added the documentation Improvements or additions to documentation label May 16, 2023
@JamesMGreene JamesMGreene added the GHES Specific to GitHub Enterprise Server label Dec 2, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation GHES Specific to GitHub Enterprise Server
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants