Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keep the extension of the original file when none was given #2420

Merged
merged 2 commits into from
Dec 10, 2024

Conversation

gnunicorn
Copy link
Contributor

Fixes #2415 by making files downloaded always have extensions - if none was given, we use the original one.

See it in action. Notice that I removed the extension but it is saved with it.

keeping-the-extensions-in-download.mp4

@gnunicorn gnunicorn added bug Something isn't working flutter labels Dec 9, 2024
Copy link

codecov bot commented Dec 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 27.55%. Comparing base (6769dd6) to head (d8cb4f6).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2420   +/-   ##
=======================================
  Coverage   27.55%   27.55%           
=======================================
  Files         649      649           
  Lines       43788    43791    +3     
=======================================
+ Hits        12065    12066    +1     
- Misses      31723    31725    +2     
Flag Coverage Δ
integration-test 37.48% <ø> (+<0.01%) ⬆️
unittest 19.46% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@kumarpalsinh25 kumarpalsinh25 merged commit 8152995 into main Dec 10, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working flutter
Projects
Status: Recently Done
Development

Successfully merging this pull request may close these issues.

saving a file without extensions means it can't be opened
2 participants