Merge pull request #2420 from acterglobal/ben-keep-file-extension-for…

…-download-file

Keep the extension of the original file when none was given

.changes/2420-keep-file-extension.md

@@ -0,0 +1 @@
+- Fix: when downloading as file, keep the extension even if the user removed it to ensure they can open the resulting file.

app/lib/features/files/actions/download_file.dart

@@ -1,5 +1,5 @@
 import 'dart:io';
-import 'package:path/path.dart';
+import 'package:path/path.dart' as p;
 
 import 'package:file_picker/file_picker.dart';
 import 'package:flutter/material.dart';
@@ -8,7 +8,8 @@ import 'package:flutter_easyloading/flutter_easyloading.dart';
 
 Future<bool> downloadFile(BuildContext context, File file) async {
   final lang = L10n.of(context);
-  final filename = basename(file.path);
+  final filename = p.basename(file.path);
+  final extension = p.extension(filename);
   String? outputFile = await FilePicker.platform.saveFile(
     dialogTitle: lang.downloadFileDialogTitle,
     fileName: filename,
@@ -18,6 +19,11 @@ Future<bool> downloadFile(BuildContext context, File file) async {
     return false;
   }
 
+  if (p.extension(outputFile).isEmpty) {
+    // the new file doesn't have an extension, we add the previous one again
+    outputFile = '$outputFile$extension';
+  }
+
   await file.copy(outputFile);
   EasyLoading.showToast(lang.downloadFileSuccess(outputFile));
   return true;