Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more examples for tests and development #16

Open
robinlovelace-ate opened this issue Jul 19, 2023 · 2 comments · May be fixed by #17
Open

Add more examples for tests and development #16

robinlovelace-ate opened this issue Jul 19, 2023 · 2 comments · May be fixed by #17

Comments

@robinlovelace-ate
Copy link
Contributor

As illustrated below, thinking of using ATIP for this...

image

@dabreegster
Copy link
Contributor

Thanks! I'll look at the PR soon. But just FYI, I don't plan on doing any more work on this repo, because there's no need for it. The approach I started in https://github.com/dabreegster/routing-engines where summing counts by (OSM node1, node2) pairs and looking up geometry and edge attributes later is going to be much more performant, simpler, and avoid hairy issues with bridge/tunnel crossings. I'll try and write up that approach in more detail and send it around tomorrow

@robinlovelace-ate
Copy link
Contributor Author

Sounds good Dustin, I think your approach with using the nodes directly sounds really good. 👍 to performance, simplicity and avoiding hairy issues (from which the R implementation of overline() may suffer from as it has few tests).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants