From 3fa83803b0f4666e75d9331f4b10631c9da15b4b Mon Sep 17 00:00:00 2001
From: Pete-Y-CS <133757676+Pete-Y-CS@users.noreply.github.com>
Date: Mon, 14 Oct 2024 10:32:24 +0100
Subject: [PATCH] rework wording of file management (#90)

* rework wording of file management

* File management pr changes

---------

Co-authored-by: Peter York <peter.york@dft.gov.uk>
---
 src/lib/files/FileManager.svelte         | 20 ++++++++++----------
 src/routes/area_check/+page@.svelte      |  8 +++++++-
 src/routes/area_check/files/+page.svelte |  8 +++++++-
 src/routes/cross_section/+page@.svelte   |  8 +++++++-
 src/routes/planning/+page@.svelte        |  1 +
 src/routes/route_check/+page@.svelte     |  1 +
 6 files changed, 33 insertions(+), 13 deletions(-)

diff --git a/src/lib/files/FileManager.svelte b/src/lib/files/FileManager.svelte
index b47f20a5c9..227673c150 100644
--- a/src/lib/files/FileManager.svelte
+++ b/src/lib/files/FileManager.svelte
@@ -18,6 +18,8 @@
   // eslint-disable-next-line no-undef
   export let state: Writable<StateType>;
   export let service: string;
+  // A singular noun like "scheme". The plural noun is assumed to just need an "s" appended
+  export let fileObjectType: string;
 
   // If provided, adds an option to import from an XLSX file. Runs the callback
   // with the ArrayBuffer to produce State. This should throw exceptions if
@@ -125,16 +127,16 @@
 <div class="govuk-width-container">
   <AlphaBanner />
 
-  <h1 style="margin-top: 30px">Manage my schemes</h1>
+  <h1 style="margin-top: 30px">Manage my {fileObjectType}s</h1>
 
   <div class="govuk-grid-row">
     <div class="govuk-grid-column-two-thirds">
       <slot name="description" />
 
       <p>
-        All files are auto-saved in your browser's local storage. You can close
-        your browser and resume later. You can export the file to your computer
-        to share with someone else, and import from a file below.
+        On this page you can manage your {fileObjectType} files. All files are auto-saved
+        in your browser's local storage. You can close your browser and continue
+        later.
       </p>
 
       {#if $currentFile}
@@ -187,12 +189,10 @@
     </div>
 
     <div class="govuk-grid-column-one-third">
-      <h2 class="green-bar">Create or import a file</h2>
-      <SecondaryButton on:click={newFile}>
-        New blank scheme file
-      </SecondaryButton>
-      <hr />
-      <FileInput label="Import from a .json file" onLoad={importJsonFile} />
+      <h2 class="green-bar">Create a new {fileObjectType}</h2>
+      <SecondaryButton on:click={newFile}>Create new file</SecondaryButton>
+      <h2>Import a saved {fileObjectType}</h2>
+      <FileInput label={`Select a .json file`} onLoad={importJsonFile} />
 
       {#if xlsxImporter != null}
         <hr />
diff --git a/src/routes/area_check/+page@.svelte b/src/routes/area_check/+page@.svelte
index 094c92ad53..26805b05f0 100644
--- a/src/routes/area_check/+page@.svelte
+++ b/src/routes/area_check/+page@.svelte
@@ -3,4 +3,10 @@
   import { files, currentFile, state } from "./data";
 </script>
 
-<FileManager {files} {currentFile} {state} service="Area Check Tool" />
+<FileManager
+  {files}
+  {currentFile}
+  {state}
+  service="Area Check Tool"
+  fileObjectType="scheme"
+/>
diff --git a/src/routes/area_check/files/+page.svelte b/src/routes/area_check/files/+page.svelte
index b641b8d8aa..f657e11280 100644
--- a/src/routes/area_check/files/+page.svelte
+++ b/src/routes/area_check/files/+page.svelte
@@ -3,4 +3,10 @@
   import { files, currentFile, state } from "../data";
 </script>
 
-<FileManager {files} {currentFile} {state} service="Area Check Tool" />
+<FileManager
+  {files}
+  {currentFile}
+  {state}
+  service="Area Check Tool"
+  fileObjectType="scheme"
+/>
diff --git a/src/routes/cross_section/+page@.svelte b/src/routes/cross_section/+page@.svelte
index 3387327316..60b572aa87 100644
--- a/src/routes/cross_section/+page@.svelte
+++ b/src/routes/cross_section/+page@.svelte
@@ -3,4 +3,10 @@
   import { files, currentFile, state } from "./data";
 </script>
 
-<FileManager {files} {currentFile} {state} service="Cross Section Check Tool" />
+<FileManager
+  {files}
+  {currentFile}
+  {state}
+  service="Cross Section Check Tool"
+  fileObjectType="cross section"
+/>
diff --git a/src/routes/planning/+page@.svelte b/src/routes/planning/+page@.svelte
index 7efe2e0801..d60a3b0f29 100644
--- a/src/routes/planning/+page@.svelte
+++ b/src/routes/planning/+page@.svelte
@@ -8,4 +8,5 @@
   {currentFile}
   {state}
   service="Planning Application Assessment Toolkit"
+  fileObjectType="assessment"
 />
diff --git a/src/routes/route_check/+page@.svelte b/src/routes/route_check/+page@.svelte
index af88a898c8..d554c84a46 100644
--- a/src/routes/route_check/+page@.svelte
+++ b/src/routes/route_check/+page@.svelte
@@ -18,6 +18,7 @@
   {state}
   {xlsxImporter}
   service="Route Check Tool"
+  fileObjectType="scheme"
 >
   <p slot="description">
     The Route Check Tool is used by ATE for assessing the design quality of