-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Could it use β instead of βοΈ? π #192
Comments
I'm not against changing it but what if someone comes back asking for it to be changed back? Would making it configurable work? And how would you make the config change? Using config options like this ... https://github.com/actions/checkout#usage or an environment variable? Suggestions welcome and much appreciated. |
Honestly, I don't think the icon is so important it needs a separate config option. The issue was opened without much thinking mainly out of curiosity and for fun as my colleagues and I agreed that the green icon (β ) would look better. We like the package and this is just a small thing we noticed π Nevertheless if you want to update it, some optional config option should work I think π |
Unfortunately the suggested check mark looks a lot worse on mobile, so π π’ |
Can be configured in
Fixed by #206 |
IMHO, it just looks cooler π€·ββοΈ π
βοΈ -> β
slack/src/slack.ts
Line 13 in e4e7168
The text was updated successfully, but these errors were encountered: