Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could it use βœ… instead of βœ”οΈ? πŸ˜‚ #192

Closed
jozefcipa opened this issue Dec 14, 2020 · 6 comments
Closed

Could it use βœ… instead of βœ”οΈ? πŸ˜‚ #192

jozefcipa opened this issue Dec 14, 2020 · 6 comments
Labels
wontfix This will not be worked on

Comments

@jozefcipa
Copy link

IMHO, it just looks cooler πŸ€·β€β™‚οΈ πŸ˜…

βœ”οΈ -> βœ…

if (status.toLowerCase() === 'success') return ':heavy_check_mark:'

@satterly
Copy link
Contributor

I'm not against changing it but what if someone comes back asking for it to be changed back?

Would making it configurable work? And how would you make the config change? Using config options like this ... https://github.com/actions/checkout#usage or an environment variable? Suggestions welcome and much appreciated.

@jozefcipa
Copy link
Author

jozefcipa commented Dec 14, 2020

Honestly, I don't think the icon is so important it needs a separate config option. The issue was opened without much thinking mainly out of curiosity and for fun as my colleagues and I agreed that the green icon (βœ…) would look better. We like the package and this is just a small thing we noticed πŸ˜… Nevertheless if you want to update it, some optional config option should work I think πŸ‘

@satterly
Copy link
Contributor

satterly commented Jan 3, 2021

On desktop ...
Screenshot 2021-01-03 at 22 18 46

On mobile ...
Screenshot 2021-01-03 at 22 18 46

@satterly
Copy link
Contributor

satterly commented Jan 3, 2021

Unfortunately the suggested check mark looks a lot worse on mobile, so πŸ‘Ž 😒

@satterly satterly closed this as completed Jan 3, 2021
@satterly satterly added the wontfix This will not be worked on label Jan 3, 2021
@satterly
Copy link
Contributor

satterly commented Oct 29, 2021

Can be configured in .github/slack.yml ...

icons:
  success: ':white_check_mark:'
  failure: ':grimacing:'
  cancelled: ':x:'
  skipped: ':heavy_minus_sign:'
  default: ':interrobang:'

Fixed by #206

@satterly
Copy link
Contributor

Screenshot 2021-10-29 at 17 51 50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

2 participants