Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DX-5800: Acquia\Blt\Robo\Common\EnvironmentDetector::getSiteName($site_path) must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::getSiteName(string $site_path): ?string in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php #4597

Closed
bmartinez287 opened this issue Sep 8, 2022 · 4 comments
Labels
Bug Something isn't working

Comments

@bmartinez287
Copy link

Changes made to https://github.com/acquia/drupal-environment-detector require for this to be updated:

  • Acquia\Blt\Robo\Common\EnvironmentDetector::getSiteName($site_path)
  • Acquia\Blt\Robo\Common\EnvironmentDetector::isLocalEnv()

PHP Fatal error: Declaration of Acquia\Blt\Robo\Common\EnvironmentDetector::getSiteName($site_path) must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::getSiteName(string $site_path): ?string in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php on line 236

Fatal error: Declaration of Acquia\Blt\Robo\Common\EnvironmentDetector::getSiteName($site_path) must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::getSiteName(string $site_path): ?string in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php on line 236
[warning] Drush command terminated abnormally.

PHP Fatal error: Declaration of Acquia\Blt\Robo\Common\EnvironmentDetector::isLocalEnv() must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::isLocalEnv(): bool in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php on line 105

Fatal error: Declaration of Acquia\Blt\Robo\Common\EnvironmentDetector::isLocalEnv() must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::isLocalEnv(): bool in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php on line 105
[warning] Drush command terminated abnormally.

@bmartinez287 bmartinez287 added the Bug Something isn't working label Sep 8, 2022
@bmartinez287 bmartinez287 changed the title DX-5800: test jira integration DX-5800: Declaration of Acquia\Blt\Robo\Common\EnvironmentDetector::getSiteName($site_path) must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::getSiteName(string $site_path): ?string in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php Sep 8, 2022
@github-actions github-actions bot changed the title DX-5800: Declaration of Acquia\Blt\Robo\Common\EnvironmentDetector::getSiteName($site_path) must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::getSiteName(string $site_path): ?string in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php DX-5166: DX-5800: test jira integration Sep 8, 2022
@bmartinez287 bmartinez287 changed the title DX-5166: DX-5800: test jira integration DX-5800: Acquia\Blt\Robo\Common\EnvironmentDetector::getSiteName($site_path) must be compatible with Acquia\DrupalEnvironmentDetector\AcquiaDrupalEnvironmentDetector::getSiteName(string $site_path): ?string in /app/vendor/acquia/blt/src/Robo/Common/EnvironmentDetector.php Sep 8, 2022
@mikemadison13
Copy link
Contributor

Hi @bmartinez287 what version of BLT are you running?

@bmartinez287
Copy link
Author

bmartinez287 commented Sep 8, 2022

I was running 13.3 because we had some issues with 13.4. But I just saw this is fixed on 13.5.
That said can we merge this acquia/blt-travis#4? That came up after. Thanks for the quick feedback @mikemadison13

@joejoseph00
Copy link

joejoseph00 commented Apr 12, 2023

@bmartinez287 I just hit this because the acquia documentation is outdated

https://docs.acquia.com/blt/install/adding-to-project/

Could you please update the acquia documentation to read ^13 instead of ^13.0 ?

see link ^^^

@joejoseph00
Copy link

#4674

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants