Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5.5.1 release have weird timestamps #680

Closed
andreypopp opened this issue Mar 7, 2018 · 5 comments
Closed

5.5.1 release have weird timestamps #680

andreypopp opened this issue Mar 7, 2018 · 5 comments

Comments

@andreypopp
Copy link

After installing [email protected] I get files with weird timestamps (only manifests itself on Linux, fine on macOS). This breaks some other tooling which doesn't expect timestamp to be such old.

andrey@dev:~$ npm i [email protected]
/home/andrey
└── [email protected]

npm WARN enoent ENOENT: no such file or directory, open '/home/andrey/package.json'
npm WARN andrey No description
npm WARN andrey No repository field.
npm WARN andrey No README data
npm WARN andrey No license field.
andrey@dev:~$ ls -la node_modules/acorn//dist/
total 492
drwxr-xr-x 2 andrey developer   4096 Mar  7 21:18 .
drwxr-xr-x 4 andrey developer   4096 Mar  7 21:18 ..
-rw-r--r-- 1 andrey developer 177992 Jan  1  1970 acorn.es.js
-rw-r--r-- 1 andrey developer 178723 Jan  1  1970 acorn.js
-rw-r--r-- 1 andrey developer  47367 Jan  1  1970 acorn_loose.es.js
-rw-r--r-- 1 andrey developer  49344 Jan  1  1970 acorn_loose.js
-rw-r--r-- 1 andrey developer      0 Jan  1  1970 .keep
-rw-r--r-- 1 andrey developer  14005 Jan  1  1970 walk.es.js
-rw-r--r-- 1 andrey developer  14592 Jan  1  1970 walk.js
@marijnh
Copy link
Member

marijnh commented Mar 8, 2018

I can't reproduce this. NPM (5.7.1) seems to create files using the current date. The dates in my build dir are also not set to 0, so I'm not sure where this might be coming from. Have you verified that this is Acorn-related?

@andreypopp
Copy link
Author

I have an old [email protected] on my server. Yes only this exact version of acorn has this problem — tried the prev one 5.5.0 and it had okish timestamps.

@marijnh
Copy link
Member

marijnh commented Mar 8, 2018

#681 suggests that 5.1.2 also has it. This seems to have come up before in UglifyJS. I suspect it's an NPM bug (once again).

I'v just published a 5.5.2 but it has the same issue. I'll try again with yarn, I guess... hold on.

@marijnh
Copy link
Member

marijnh commented Mar 8, 2018

I couldn't get yarn to publish, for weird login-related reasons, but I downgraded to NPM 5.6.0 and republished, and acorn 5.5.3 seems to have non-zero timestamps.

Software is bad, actually.

@andreypopp
Copy link
Author

Thanks for the fix, trying it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants