Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: switch types from otto to obot #1137

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

thedadams
Copy link
Contributor

No description provided.

@@ -0,0 +1,3 @@
package obotobotplatformai

var Group = "obot.obot.ai"
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How do we feel about this group?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't love the stutter, but I'm not sure if obot.ai or core.obot.ai are any better.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The other thing I considered was obot.obot-platform.ai. I switched it to this because we actually own obot.ai.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kind of weird to have two obot....but I have no opinion

Copy link
Member

@njhale njhale left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

ThreadID: resp.Header.Get("X-Otto-Thread-Id"),
ThreadID: resp.Header.Get("X-Obot-Thread-Id"),
Copy link
Member

@njhale njhale Jan 7, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Might make migration easier if we fall back to the old header if the new one isn't set.

@@ -160,3 +171,29 @@ func (c *Controller) setupRoutes() error {
c.toolRefHandler = toolRef
return nil
}

func removeOldFinalizers(req router.Request, _ router.Response) error {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this the only migration we need to be doing?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We also need to delete the models so they can be recreated with the new owner's reference.

Copy link
Contributor

@iwilltry42 iwilltry42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the stutter in the group name is weird, but I see no "real" problem with it.

@thedadams thedadams force-pushed the change-otto-types branch 2 times, most recently from 0dd75a0 to b805d0d Compare January 8, 2025 11:13
@thedadams thedadams merged commit 1a2e386 into obot-platform:main Jan 8, 2025
3 checks passed
@thedadams thedadams deleted the change-otto-types branch January 8, 2025 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants