-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: switch types from otto to obot #1137
Conversation
@@ -0,0 +1,3 @@ | |||
package obotobotplatformai | |||
|
|||
var Group = "obot.obot.ai" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How do we feel about this group?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't love the stutter, but I'm not sure if obot.ai
or core.obot.ai
are any better.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The other thing I considered was obot.obot-platform.ai
. I switched it to this because we actually own obot.ai
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
kind of weird to have two obot....but I have no opinion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
ThreadID: resp.Header.Get("X-Otto-Thread-Id"), | ||
ThreadID: resp.Header.Get("X-Obot-Thread-Id"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Might make migration easier if we fall back to the old header if the new one isn't set.
71c8807
to
d869d00
Compare
pkg/controller/routes.go
Outdated
@@ -160,3 +171,29 @@ func (c *Controller) setupRoutes() error { | |||
c.toolRefHandler = toolRef | |||
return nil | |||
} | |||
|
|||
func removeOldFinalizers(req router.Request, _ router.Response) error { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this the only migration we need to be doing?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We also need to delete the models so they can be recreated with the new owner's reference.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the stutter in the group name is weird, but I see no "real" problem with it.
0dd75a0
to
b805d0d
Compare
Signed-off-by: Donnie Adams <[email protected]>
b805d0d
to
8af5333
Compare
No description provided.