-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
🚦HTTP -> HTTPS Redirection for Sparkhacks. #95
Conversation
I fixed the linter but it absolutely hates every yaml file, so it fails. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm glad we're actually linting now! Yay! 🎉
annotations: | ||
kube-linter.io/ignore-all: "Wtf even is this?" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we create an issue to fix whatever the linter is complaining about?
Document the errors in the issue, so we know at least what needs to be fixed.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Uuh, okay. Is it okay if I do that in a new PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Most definitely in a different PR. I'm just saying to create a new Github issue so we don't totally lose track of that work.
@@ -63,6 +63,7 @@ metadata: | |||
spec: | |||
entryPoints: | |||
- websecure | |||
- web |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If you are doing a redirect, then you wouldn't add an entrypoint here. You'd likely use another IngressRoute
with some redirect logic instead.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we add redirects for the entire web
entry point, this probably doesn't need to be here unless you still expect to serve the actual website over HTTP.
- Add BMES website https://convergehealth.cc - Revert #95 to allow cert-manager to work again - Deploy wordpress for BMES. - ??? - Profit
No description provided.