Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚦HTTP -> HTTPS Redirection for Sparkhacks. #95

Merged
merged 11 commits into from
Jan 28, 2024
Merged

🚦HTTP -> HTTPS Redirection for Sparkhacks. #95

merged 11 commits into from
Jan 28, 2024

Conversation

SohamG
Copy link
Contributor

@SohamG SohamG commented Jan 27, 2024

No description provided.

@SohamG SohamG requested a review from clee231 January 27, 2024 17:18
@SohamG
Copy link
Contributor Author

SohamG commented Jan 27, 2024

I fixed the linter but it absolutely hates every yaml file, so it fails.

@SohamG SohamG enabled auto-merge (squash) January 27, 2024 17:48
@SohamG SohamG disabled auto-merge January 27, 2024 18:02
@SohamG SohamG enabled auto-merge (squash) January 27, 2024 18:05
Copy link
Contributor

@clee231 clee231 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm glad we're actually linting now! Yay! 🎉

kubernetes/argocd/stacks/traefik/values.yml Outdated Show resolved Hide resolved
Comment on lines +26 to +27
annotations:
kube-linter.io/ignore-all: "Wtf even is this?"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we create an issue to fix whatever the linter is complaining about?
Document the errors in the issue, so we know at least what needs to be fixed.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uuh, okay. Is it okay if I do that in a new PR?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most definitely in a different PR. I'm just saying to create a new Github issue so we don't totally lose track of that work.

@@ -63,6 +63,7 @@ metadata:
spec:
entryPoints:
- websecure
- web
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If you are doing a redirect, then you wouldn't add an entrypoint here. You'd likely use another IngressRoute with some redirect logic instead.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we add redirects for the entire web entry point, this probably doesn't need to be here unless you still expect to serve the actual website over HTTP.

@SohamG SohamG merged commit d7d7ce8 into main Jan 28, 2024
1 check failed
@SohamG SohamG deleted the webredirect branch January 28, 2024 19:57
SohamG added a commit that referenced this pull request Oct 19, 2024
- Add BMES website https://convergehealth.cc
- Revert #95 to allow cert-manager to work again
- Deploy wordpress for BMES.
- ???
- Profit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants