Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge search inputs into one, add spell drop overlays as POIs #69

Open
WUOTE opened this issue Dec 6, 2024 · 1 comment
Open

Merge search inputs into one, add spell drop overlays as POIs #69

WUOTE opened this issue Dec 6, 2024 · 1 comment
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@WUOTE
Copy link
Contributor

WUOTE commented Dec 6, 2024

I believe these should be addressed simultaneously:

  1. There is a request from the wiki people:

is there a way to link to a specific spell overlay? I'll add something to the spell infobox

  1. Having a second search box just for spells is confusing, so I'd like to see them merged into one. As for how to fix two different behaviors when selecting a POI, and a spell: selecting a spell in the search results -- the “go to the POI” should frame all the overlays that are active + toggle overlays.
@WUOTE WUOTE added enhancement New feature or request help wanted Extra attention is needed labels Dec 6, 2024
@WUOTE WUOTE added this to Noitamap Dec 6, 2024
@ashleybaldock
Copy link

I suggest making the variable part of the inbound links be just the Spell ID (if possible), as it makes it easy to include links to them from other tools - you only need to know the base URL and ID to generate a link. (All the spell wiki pages implement this via a redirect from their ID, e.g. https://noita.wiki.gg/wiki/MANA_REDUCE -> https://noita.wiki.gg/wiki/Add_Mana)

@WUOTE WUOTE moved this to Evaluating in Noitamap Dec 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
Status: Evaluating
Development

No branches or pull requests

2 participants