Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix #41 and #39 #43

Merged
merged 4 commits into from
Apr 28, 2014
Merged

fix #41 and #39 #43

merged 4 commits into from
Apr 28, 2014

Conversation

Centaur
Copy link
Contributor

@Centaur Centaur commented Apr 10, 2014

There are some plugin api changes from idea 13 to 13.1 and I made some code changes that I believe won't compile in 13. If you still need to support versions before 13.1 on master then please create a '13.1' branch and I will send another pull request.

@johnlindquist
Copy link
Collaborator

Awesome, I'll merge when I get home this weekend.

@Centaur
Copy link
Contributor Author

Centaur commented Apr 10, 2014

Sorry I did not figure out how to exclude commits 5d93 and c95d.

@markmandel
Copy link

I've been testing this out on my 13.1.2 install, and it's been rock solid.

johnlindquist added a commit that referenced this pull request Apr 28, 2014
@johnlindquist johnlindquist merged commit 44617e9 into acejump:master Apr 28, 2014
@johnlindquist
Copy link
Collaborator

Nuts, this broke focus on Mac OSX :/ I guess I'll have to detect the platform and switch between your fix and my old stuff.

@hoshsadiq
Copy link

Is there a time scale for when you will update the plugin repository?

@johnlindquist
Copy link
Collaborator

If you're on Linux, just download the .zip from the repo and install it through Prefs->Plugins->Install plugin from disk. It should be the "fixed" Linux version. The Mac/Win version is still in the main plugin repo.

Hopefully I can make some time this week to do the platform detection and use the fixes.

@hoshsadiq
Copy link

I am indeed! I will install it from there. Thanks!

@rocketraman
Copy link

👍

@breandan
Copy link
Collaborator

I was unsuccessful in reproducing any broken focus with the latest master on IC-144.3600.7 on Mac OS X 10.11.3. Unless there are any objections, I am going to publish an update to the Plugin Repo as per request #55.

@breandan
Copy link
Collaborator

As there are no objections, I am publishing the latest release containing these changes to the JetBrains plugin repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants