Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

keyword option for DHCR #90

Closed
ehanscam opened this issue Sep 28, 2023 · 5 comments
Closed

keyword option for DHCR #90

ehanscam opened this issue Sep 28, 2023 · 5 comments
Labels
admin Admin - Part of application featurerequest New feature request - Kind of issue frontend Front End - Part of application specsmissing Development can’t start because specifications are missing – Status of issue

Comments

@ehanscam
Copy link

Hello,

It would be great to have the option to tag courses with keywords, so we can search by tag and note the national infrastructure involved, for instance.

@patrickakk patrickakk added featurerequest New feature request - Kind of issue frontend Front End - Part of application labels Oct 2, 2023
@patrickakk
Copy link
Contributor

@IvdL22 @PixlTracer @vronk See the request above as info.

It's related to this issue: #88

@patrickakk patrickakk added admin Admin - Part of application specsmissing Development can’t start because specifications are missing – Status of issue labels Oct 2, 2023
@patrickakk patrickakk added this to the November 2023 milestone Oct 2, 2023
@patrickakk
Copy link
Contributor

patrickakk commented Oct 2, 2023

Added SpecsMissing label, see other issue.

Added to November milestone so it stays in focus and we can discuss this in one of the following meetings.
Then we can take a decision? And reschedule the issue?

@PixlTracer
Copy link

proposal:
when entering (writing) something in the search bar --> hit enter
--> a checkbox appears "also search in course description"
when ticking this box, the system crawls the metadata content of the course description field

@patrickakk
Copy link
Contributor

@PixlTracer
Can we see this as part of the bigger issue, here: #88

A few remarks:

  • It's not that difficult to implement a search in the description.
  • This issue is about adding a tag/keyword to a course, not searching in the description?
  • The current behavior of the search bar is to respond to every character which is entered (typeahead) without pressing enter. Do you suggest to change this?
  • The suggested checkbox could also be shown by default?
  • What when the search in the description is implemented and then we decide to add tags?

Can we please continue (or start) the discussion in the other issue?

@patrickakk patrickakk removed this from the November 2023 milestone Nov 15, 2023
@vronk
Copy link

vronk commented Dec 6, 2023

This will be tackled in course of revamping the search, cf. #88

@vronk vronk closed this as completed Dec 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
admin Admin - Part of application featurerequest New feature request - Kind of issue frontend Front End - Part of application specsmissing Development can’t start because specifications are missing – Status of issue
Projects
None yet
Development

No branches or pull requests

4 participants