fix(ui-markdown-editor): Fixes functionalities of the toolbar in mark… #367
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 15, 2022 00:30
…down editor - # 364 Signed-off-by: Abhijith Ganesh <[email protected]>
Signed-off-by: Abhijith Ganesh <[email protected]>
dselman
requested changes
Jan 19, 2022
AbhijithGanesh
commented
Jan 29, 2022
Comment on lines
117
to
127
| setSlateValue(slateChildren); | ||
| const edited_markdown = slateTransformer.toMarkdown(SlateValue); | ||
|
|
||
| /* | ||
| Actions are a feature of stories which allow live changes to be recorded in an action. | ||
| (https://storybook.js.org/docs/react/essentials/actions#gatsby-focus-wrapper) | ||
| */ | ||
|
|
||
| action("onSlateValueChange")(slateChildren); | ||
| action("setMarkdown")(edited_markdown); | ||
| }); |
There was a problem hiding this comment.
@dselman If you see here, I changed how the way Markdown is rendered, it previously didn't render the ordered lists correctly. After these changes, It renders correctly. I have also mentioned the docs related to storybook
Signed-off-by: Abhijith Ganesh <[email protected]>
Signed-off-by: Abhijith Ganesh <[email protected]>
) Signed-off-by: TC5022 <[email protected]> Signed-off-by: Abhijith Ganesh <[email protected]>
…down editor - # 364 Signed-off-by: Abhijith Ganesh <[email protected]>
Signed-off-by: Abhijith Ganesh <[email protected]>
Signed-off-by: Abhijith Ganesh <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…down editor - # 364
Signed-off-by: Abhijith Ganesh [email protected]
Closes #364
Changes
useMemobugs, moved touseStateanduseCallbackActionFlags
Screenshots or Video
Author Checklist
--signoffoption of git commit.masterfromfork:branchname