Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change in Demo Text Of Markdown Editor #339

Open
d-e-v-esh opened this issue May 6, 2021 · 2 comments · May be fixed by #370
Open

Change in Demo Text Of Markdown Editor #339

d-e-v-esh opened this issue May 6, 2021 · 2 comments · May be fixed by #370

Comments

@d-e-v-esh
Copy link
Contributor

d-e-v-esh commented May 6, 2021 •
edited
Loading

Bug Report 🐛

As we have discussed in this thread and in this post, we should replace the terminology of hardBreak and softBreak with lineBreak and paragraphBreak that is causing confusion.

@jeromesimeon also suggested to do the same here.
We are not going to be using those terminologies in the code so having them in the UI will just create more confusion in the future.
This would obviously make more sense after #270 is resolved and implemented.

In the deploy preview of #270, this is how the demo text appears.

Current Behavior

chrome_WGN8HYULHq

Expected Behavior

chrome_z6q4JdDvhz

lineBreak => shift + enter
paragraphBreak => enter

Desktop

  • OS: Windows 10
  • Browser: Chrome
  • Version 90.0.4430.93 (Official Build) (64-bit)
@jolanglinais
Copy link
Member

@jeromesimeon pinging you on this again. If this looks good, please label it.

@Pravenn18
Copy link

I have fixed this issue #370 please review it and closes the issue

@jolanglinais jolanglinais linked a pull request Jan 21, 2022 that will close this issue
fix(storybook): use paragraph break in example - #339 #370
Open
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(storybook): use paragraph break in example - #339 Pravenn18/web-components
3 participants
@jolanglinais @d-e-v-esh @Pravenn18