Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ui-markdown-editor): reading style type of hyper links #299

Closed
wants to merge 1 commit into from
Closed

fix(ui-markdown-editor): reading style type of hyper links #299

wants to merge 1 commit into from

Conversation

Cronus1007
Copy link
Contributor

@Cronus1007 Cronus1007 commented Mar 12, 2021 •
edited
Loading

Closes #296

If there is no selection made by the editor an error is shown in console.log so added an if else based upon the editor.selection and the error that is shown in console.log disappears.

Changes

  • Added an if else clause to check editor.selection whether selection was made or not.

Screenshots or Video

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to master from fork:branchname
  • Manual accessibility test performed
    • Keyboard-only access, including forms
    • Contrast at least WCAG Level A
    • Appropriate labels, alt text, and instructions

@Cronus1007 Cronus1007 changed the title feat(ui-markdown-editor): reading style type of hyper links fix(ui-markdown-editor): reading style type of hyper links Mar 12, 2021
@d-e-v-esh
Copy link
Contributor

This does not look like it solves the issue. The issue is not that the error appears and we need to hide the error in the console. The issue is not being able to calculate the block type of hyperlinks because editor.selection goes null as soon as the pop-up appears.

@mttrbrts
Copy link
Member

This does not look like it solves the issue. The issue is not that the error appears and we need to hide the error in the console. The issue is not being able to calculate the block type of hyperlinks because editor.selection goes null as soon as the pop-up appears.

Thanks @d-e-v-esh , I agree with your analysis. @Cronus1007, I'm going to close your PR until we've been able to more research into the root cause.

@mttrbrts mttrbrts closed this Mar 12, 2021
@mttrbrts mttrbrts self-requested a review March 12, 2021 10:11
@mttrbrts mttrbrts added the Type: Bug 🐛 Something isn't working label Mar 12, 2021
@Cronus1007 Cronus1007 deleted the issue-296 branch March 12, 2021 10:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mttrbrts mttrbrts Awaiting requested review from mttrbrts

Assignees
No one assigned
Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Cannot read style type of hyperlinks
3 participants
@Cronus1007 @d-e-v-esh @mttrbrts