Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle Underline in Markdown #28

Open
jolanglinais opened this issue Oct 3, 2019 · 7 comments
Open

Handle Underline in Markdown #28

jolanglinais opened this issue Oct 3, 2019 · 7 comments

Comments

@jolanglinais
Copy link
Member

jolanglinais commented Oct 3, 2019

To Be Done Instead of OR After Issue #27

Since transitioning to utilize the markdown-transform, we will need to take a step back from supporting underline for the time being. Markdown doesn't natively support underline, so we need to rethink how we serialise this.

We can then experiment with using html tags for underline.

@ahmedkrmn
Copy link

Since issue accordproject/markdown-editor#97 is now closed, can I start working on this?

@jolanglinais
Copy link
Member Author

Yes @ahmedkrmn! Keep a lookout for the changes @dselman and I are making with the markdown-transform, because there may be an update that could possibly affect how you approach this. Not sure if it actually will, just keep an eye out. We should be finished with that either tomorrow or early Monday (October 6/7).

@jolanglinais
Copy link
Member Author

@ahmedkrmn what is the status of this? I'm opening it back up for the time being.

@d-e-v-esh
Copy link
Contributor

@irmerk Can I look into this?

@jolanglinais
Copy link
Member Author

@d-e-v-esh I believe this may actually require thinking/work in https://github.com/accordproject/markdown-transform first. It could be worth opening an Issue there to discuss how to (or if to) handle underline in markdown.

@d-e-v-esh
Copy link
Contributor

@irmerk Yes. I think we can open another issue on this. Underlining text seems like it could be important for people dealing with contracts. Should I open another issue on this? This one will get closed?

@jolanglinais
Copy link
Member Author

If you could open one in markdown-transform and link this one, we can put a pause on this one until that new one is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants