-
Notifications
You must be signed in to change notification settings - Fork 104
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
volumediscountolist template has linked variables #175
Comments
Looking at this now. |
@dselman Can I work on this issue? |
Of course. This is a challenging one I think, based on the preliminary analysis I did. I think the fix needs to go into the CiceroMark <-> Slate transformation in the Basically, if we hit one of the Variable types and are inside a ListBlock then we should modify the name of the Variable to include the index from the ListBlock. I.e, we will end up with something like: <ul>
<li>VAR-1</li>
<li>VAR-2</li>
<li>VAR-3</li>
</ul> I recommend you experiment first with running the |
Great, I'm looking into this. 👍 |
@dselman I don't know what I am doing wrong but most of the things I try to run in the Can you tell me what I am doing wrong?
It shows all the commands in the readme here as |
@d-e-v-esh where are you seeing docs for 17.03.2021@11:33[~]: markus --version
0.12.12
17.03.2021@11:33[~]: markus --help
markus <cmd> [args]
Commands:
markus transform transform between two formats
Options:
--version Show version number [boolean]
--verbose, -v [default: false]
--help Show help [boolean]
17.03.2021@11:33[~]: See the documentation here. |
@irmerk Ya probably. I saw it in this repo |
@irmerk I think I almost understand how this works. Do you have any idea how I can work on this as |
Oh yikes! Yes let's open an Issue about this. Maybe the easiest fix would be to have the README just point to the docs I linked.
Hmm, which |
@irmerk I created the issue for this. You can assign that issue to me. And I also found the To process any changes made do I have to re-run the entire thing with |
I'm honestly not sure at the moment if there is a better way when editing something within |
From memory (so apologies if I'm mistaken)
I believe storybook will do a hot refresh then (it's a very long build so much better during development) (but maybe that's a separate question from dependency changes in |
Ya seems like that does not work when you make changes in the node modules. The only way I was able to make this work was by |
@dselman It works fine now. The variables look like this. Is this good? Working demo: |
@dselman @irmerk Any updates? |
I think it depends on the implementation. Is there a PR I can review? |
When editing the
volumediscountolist
template with the web-components the variables for all rows are linked and get updated simultaneously.Expected Behavior
Should be able to edit each row independently.
Current Behavior
Variables in all rows are linked.
Possible Solution
We need to distinguish between variables and variables that are inside a list.
Steps to Reproduce
The text was updated successfully, but these errors were encountered: