You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Describe the bug
If a template expects an integer for a variable, passing a string that cannot be coerced into a valid intege, results in a draft result with NaN in the text.
To Reproduce
Steps to reproduce the behavior:
Run cicero draft --data data.json --template src/acceptance-of-delivery/ where data.json is the following...
Acceptance of Delivery.
----
"Party A" will be deemed to have completed its delivery obligations
if in "Party B"'s opinion, the "Widgets" satisfies the
Acceptance Criteria, and "Party B" notifies "Party A" in writing
that it is accepting the "Widgets".
Inspection and Notice.
----
"Party B" will have NaN Business Days to inspect and
evaluate the "Widgets" on the delivery date before notifying
"Party A" that it is either accepting or rejecting the
"Widgets".
Acceptance Criteria.
----
The "Acceptance Criteria" are the specifications the "Widgets"
must meet for the "Party A" to comply with its requirements and
obligations under this agreement, detailed in "Attachment X", attached
to this agreement.
Expected behavior
If the template expects an integer and is given a string that cannot be coerced into a valid integer, draft should return an error.
The text was updated successfully, but these errors were encountered:
I think just a consequence of the current validation semantics for Concerto. See accordproject/concerto#157
Preventing this kind of surprising result will automatically happen as soon as we switch to the stricter validation semantic decided for the next version of Concerto.
Describe the bug
If a template expects an integer for a variable, passing a string that cannot be coerced into a valid intege, results in a draft result with
NaN
in the text.To Reproduce
Steps to reproduce the behavior:
cicero draft --data data.json --template src/acceptance-of-delivery/
wheredata.json
is the following...Expected behavior
If the template expects an integer and is given a string that cannot be coerced into a valid integer, draft should return an error.
The text was updated successfully, but these errors were encountered: