Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Cicero Server API with Cicero CLI #508

Open
jeromesimeon opened this issue Feb 17, 2020 · 8 comments
Open

Align Cicero Server API with Cicero CLI #508

jeromesimeon opened this issue Feb 17, 2020 · 8 comments

Comments

@jeromesimeon
Copy link
Member

Is your feature request related to a problem? Please describe.
Cicero server only supports a single version of the cicero trigger call through the /trigger endpoint. It might be interesting to extend the cicero server API to the rest of the commands (e.g., draft invoke parse).

Other improvements could include the ability to pass or create the template from a string (binary encoded) or JSON.

@adrijshikhar
Copy link

i would like to work on this issue.

@jeromesimeon
Copy link
Member Author

i would like to work on this issue.

that's great! I think there might be already some work being done by @martinhalford though, so this may need some coordination.

@martinhalford
Copy link
Member

Hi Ardrij,
I'm about to submit a PR today but very happy to see what you do and we can take the best approach.
Cheers,
...Martin

@jeromesimeon
Copy link
Member Author

Hi Ardrij,
I'm about to submit a PR today but very happy to see what you do and we can take the best approach.
Cheers,
...Martin

An initial PR would be great. We can then refine and there will likely be some follow up work in extensions / testing / documentation.

@martinhalford
Copy link
Member

Pull request submitted. I've implemented /draft and /parse. If anyone wants to have a crack at the other commands (e.g. /invoke) then go for it.

@jeromesimeon
Copy link
Member Author

Pull request submitted. I've implemented /draft and /parse. If anyone wants to have a crack at the other commands (e.g. /invoke) then go for it.

Thanks! I've merged it.

I'm leaving this issue open for now, as I think there could be further improvements as mentioned in comments.

@ankushbhardwxj
Copy link

@jeromesimeon I would like to implement the other commands , if this issue is available 👍

@jeromesimeon
Copy link
Member Author

@martinhalford Can we consider this issue closed, or is there more work to do on the Cicero server API?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants