Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conditional Variable Othertext #162

Closed
jolanglinais opened this issue Feb 6, 2020 · 2 comments
Closed

Conditional Variable Othertext #162

jolanglinais opened this issue Feb 6, 2020 · 2 comments
Assignees
Labels
0.20-ui Difficulty: Medium Type: Enhancement ✨ Improvement to process or efficiency

Comments

@jolanglinais
Copy link
Member

Cicero draft will be changed to put all conditional variables in markdown XML

This package should handle this change and put variables in the Slate object, maybe in the data of the inline?

For commonMark to ciceroMark and ciceroMark to Slate:
Adjust to handling these inlines being changed

Related issue comment by Jerome:

Late Delivery and Penalty.
----

In case of delayed delivery<if id="forceMajeure" whenTrue=" except for Force Majeure cases," whenFalse=" even when there is a Force Majeure," value="true"/>
<variable id="seller" value="%22Dan%22"/> (the Seller) shall pay to <variable id="buyer" value="%22Steve%22"/> (the Buyer) for every <variable id="penaltyDuration" value="2%20days"/>
of delay penalty amounting to <variable id="penaltyPercentage" value="10.5"/>% of the total value of the Equipment
whose delivery has been delayed. Any fractional part of a <variable id="fractionalPart" value="days"/> is to be
considered a full <variable id="fractionalPart" value="days"/>. The total amount of penalty shall not however,
exceed <variable id="capPercentage" value="55.0"/>% of the total value of the Equipment involved in late delivery.
If the delay is more than <variable id="termination" value="15%20days"/>, the Buyer is entitled to terminate this Contract.
          {
            "object": "inline",
            "type": "conditional",
            "data": {
              "id": "forceMajeure",
              "whenTrue": " except for Force Majeure cases,",
              "whenFalse": " even when there is a Force Majeure,",
              "value": false
            },
            "nodes": [
              {
                "object": "text",
                "text": " even when there is a Force Majeure,",
                "marks": []
              }
            ]
          }, 
@jolanglinais jolanglinais added Difficulty: Medium Type: Enhancement ✨ Improvement to process or efficiency 0.20-ui labels Feb 6, 2020
@jolanglinais jolanglinais self-assigned this Feb 6, 2020
@jeromesimeon
Copy link
Member

Note: the sample was done by hand, the text content for whenTrue and whenFalse should be URL-encoded. (@dselman )

@jeromesimeon
Copy link
Member

This was fixed in #180

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
0.20-ui Difficulty: Medium Type: Enhancement ✨ Improvement to process or efficiency
Projects
None yet
Development

No branches or pull requests

2 participants