Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapped Variants of Conditional blocks #130

Closed
jeromesimeon opened this issue Nov 22, 2019 · 0 comments
Closed

Wrapped Variants of Conditional blocks #130

jeromesimeon opened this issue Nov 22, 2019 · 0 comments
Assignees

Comments

@jeromesimeon
Copy link
Member

jeromesimeon commented Nov 22, 2019

Is your feature request related to a problem? Please describe.

Provide new CiceroMark nodes for variables corresponding to conditional blocks in templates.

CiceroMark variables can be either seen as plain text or wrapped (e.g., <variable id="rate" value="3.5"/>).

Conditional blocks in CiceroMark can also be wrapped, but cannot be easily distinguished from regular variables.

Conditional variables corresponding to conditional blocks are not reflected in the Slate AST, which means they cannot easily be edited by the UI components.

Describe the solution you'd like

  • A new kind of AST node in CiceroMark: ConditionalVariable
  • A new kind of AST node in Slate: conditional
  • The ability to parse/draft them. Suggested formats would be similar to variables but conditionals <if id="varName" value=""/>
  • Translations to/from markdown, Cicero and Slate.

Additional context
Support for editing of conditional and list variables in Cicero UI:
accordproject/cicero-ui#233

@jeromesimeon jeromesimeon self-assigned this Nov 22, 2019
@jeromesimeon jeromesimeon changed the title Wrapped Variants of Conditional blocks and List blocks Wrapped Variants of Conditional blocks Nov 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant