Code generation for >i is incorrect

[mttrbrts]

When the value of request.value is 1 the following executes as expected

enforce integerToDouble(request.value) > 0.0 else
      throw ErgoErrorResponse{ message: "The IOU's value must be non-negative." };

but the following returns the error response.

enforce request.value >i 0 else
      throw ErgoErrorResponse{ message: "The IOU's value must be non-negative." };

The full template including unit tests is available at https://github.com/mttrbrts/cordapp-example/tree/mr-cicero/cicero-source/corda-iou

The first example compiles to:

        var vp1 = deref(unbrand(vrequest), "value");
        var t2;
        if (!((floatOfNat(vp1) > 0.0))) {
          t2 = {"right" : brand(["org.accordproject.ergo.stdlib.ErgoErrorResponse"],{"message": "The IOU's value must be non-negative."})};
        } else {
          t2 = {"left" : concat(concat({"response": brand(["org.accordproject.cicero.runtime.Response"],{})}, {"state": vlstate}), {"emit": vlemit})};
        }

The second example compiles to:

        var t2;
        if (!(!((compare(deref(unbrand(vrequest), "value"),{"nat": 0.0}) <= 0)))) {
          t2 = {"right" : brand(["org.accordproject.ergo.stdlib.ErgoErrorResponse"],{"message": "The IOU's value must be non-negative."})};
        } else {
          t2 = {"left" : concat(concat({"response": brand(["org.accordproject.cicero.runtime.Response"],{})}, {"state": vlstate}), {"emit": vlemit})};
        }

I'm not able to reproduce this in the REPL.

[jeromesimeon]

I'll assume the issue title should say incorrect

The run-time for integer operations has several issues due to assumptions on the JSON serialization (which can be seen in the {"nat": 0.0} part of the generated code.

Some improvements on the JS code generation in Qcert should help (see #191) but for the time being, we should be able to fix it by revising the ergo runtime for Integer operations.

[jeromesimeon]

In PR #458