Concerto Core has the wrong package name #74

jeromesimeon · 2019-10-02T15:18:25Z

Describe the bug
Wrong package name.

The structure of the lerna packages in the code is:

concerto-core
concerto-tools
concerto-cli

But the package name (and the published package on npmjs) for concerto-core is still concerto. I think it would make sense to change that to avoid confusion, and align with other Accord Project packages structure/naming.

Corresponding line, I believe:

concerto/packages/concerto-core/package.json

Line 2 in 9f324a3

"name": "@accordproject/concerto",

The text was updated successfully, but these errors were encountered:

Niladri24dutta · 2019-10-02T15:38:51Z

@jeromesimeon created a PR to update the package name

jeromesimeon · 2019-10-03T13:08:30Z

Thanks @Niladri24dutta ! That's great. I would love to get @mttrbrts 's feedback on this issue since he did the refactoring into a monorepo.

mttrbrts · 2019-10-03T13:09:36Z

@jeromesimeon I've left some minor comments in the PR. otherwise it LGTM 👍

jeromesimeon · 2019-10-03T13:18:01Z

@mttrbrts Great thanks! I wanted to make sure you agree with the issue in the first place!

jeromesimeon · 2019-10-03T13:20:42Z

A few things that should be done for this:

Make sure all references across packages use the new name. Most of them are in the concerto-tools package. Here is a grep on my local copy:

bash-3.2$ grep -r require packages/*/lib | grep concerto | grep accordproject | grep -v '@accordproject/concerto-tools'
packages/concerto-cli/lib/commands.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-cli/lib/commands.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-cli/lib/commands.js:const DefaultModelFileLoader = require('@accordproject/concerto').DefaultModelFileLoader;
packages/concerto-cli/lib/commands.js:const FileWriter = require('@accordproject/concerto').FileWriter;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EventDeclaration = require('@accordproject/concerto').EventDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;

Review the READMEs/Dev instructions to make sure they refer to the new name if necessary.
I am not entirely clear, but there might be some build scripts that also refer to the package (this could be checked later).

Once the tests pass, I'll keep an eye on the deployment to npm and can help with that if need be.

Niladri24dutta · 2019-10-03T21:52:54Z

A few things that should be done for this:

* Make sure all references across packages use the new name. Most of them are in the `concerto-tools` package. Here is a grep on my local copy:

bash-3.2$ grep -r require packages/*/lib | grep concerto | grep accordproject | grep -v '@accordproject/concerto-tools'
packages/concerto-cli/lib/commands.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-cli/lib/commands.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-cli/lib/commands.js:const DefaultModelFileLoader = require('@accordproject/concerto').DefaultModelFileLoader;
packages/concerto-cli/lib/commands.js:const FileWriter = require('@accordproject/concerto').FileWriter;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/plantuml/plantumlvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/golang/golangvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/typescript/typescriptvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/xmlschema/xmlschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelUtil = require('@accordproject/concerto').ModelUtil;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/java/javavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ClassDeclaration = require('@accordproject/concerto').ClassDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/jsonschema/jsonschemavisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const AssetDeclaration = require('@accordproject/concerto').AssetDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ParticipantDeclaration = require('@accordproject/concerto').ParticipantDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ConceptDeclaration = require('@accordproject/concerto').ConceptDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumDeclaration = require('@accordproject/concerto').EnumDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EnumValueDeclaration = require('@accordproject/concerto').EnumValueDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const EventDeclaration = require('@accordproject/concerto').EventDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const Field = require('@accordproject/concerto').Field;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelFile = require('@accordproject/concerto').ModelFile;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const ModelManager = require('@accordproject/concerto').ModelManager;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const RelationshipDeclaration = require('@accordproject/concerto').RelationshipDeclaration;
packages/concerto-tools/lib/codegen/fromcto/loopback/loopbackvisitor.js:const TransactionDeclaration = require('@accordproject/concerto').TransactionDeclaration;

* Review the READMEs/Dev instructions to make sure they refer to the new name if necessary.

* I am not entirely clear, but there might be some build scripts that also refer to the package (this could be checked later).

Once the tests pass, I'll keep an eye on the deployment to npm and can help with that if need be.

I have made the requested changes in the PR

jeromesimeon · 2019-10-03T23:19:35Z

Well done @Niladri24dutta ! You PR is merged now, and the corresponding package is published on npm:
https://www.npmjs.com/package/@accordproject/concerto-core

Niladri24dutta · 2019-10-04T05:31:08Z

Well done @Niladri24dutta ! You PR is merged now, and the corresponding package is published on npm:
https://www.npmjs.com/package/@accordproject/concerto-core
@jeromesimeon
Just a question in the installation of npm document above , do we need to update the commands which refers to @accordproject/concerto e.g npm install @accordproject/concerto --save

jeromesimeon · 2019-10-04T12:47:14Z

Well done @Niladri24dutta ! You PR is merged now, and the corresponding package is published on npm:
https://www.npmjs.com/package/@accordproject/concerto-core
@jeromesimeon
Just a question in the installation of npm document above , do we need to update the commands which refers to @accordproject/concerto e.g npm install @accordproject/concerto --save

I think this is already fixed actually. It's probably just npm getting a little confused since we haven't had a first release yet. If you look at the latest tagged "unstable" version you have:
https://www.npmjs.com/package/@accordproject/concerto-core/v/0.80.4-20191004042248

(or in the repo itself)

Niladri24dutta · 2019-10-04T13:33:54Z

@jeromesimeon that makes sense now. is this PR elligible for hacktoberfest?

jeromesimeon added Type: Bug 🐛 Something isn't working Difficulty: Starter Type: Breaking Change 💥 labels Oct 2, 2019

Niladri24dutta mentioned this issue Oct 2, 2019

Update package.json for the package name concerto-core #75

Merged

jeromesimeon added the 0.20-alpha label Oct 2, 2019

jeromesimeon closed this as completed Oct 3, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Concerto Core has the wrong package name #74

Concerto Core has the wrong package name #74

jeromesimeon commented Oct 2, 2019 •

edited

Loading

Niladri24dutta commented Oct 2, 2019

jeromesimeon commented Oct 3, 2019

mttrbrts commented Oct 3, 2019

jeromesimeon commented Oct 3, 2019

jeromesimeon commented Oct 3, 2019 •

edited

Loading

Niladri24dutta commented Oct 3, 2019

jeromesimeon commented Oct 3, 2019

Niladri24dutta commented Oct 4, 2019

jeromesimeon commented Oct 4, 2019 •

edited

Loading

Niladri24dutta commented Oct 4, 2019 •

edited

Loading

Concerto Core has the wrong package name #74

Concerto Core has the wrong package name #74

Comments

jeromesimeon commented Oct 2, 2019 • edited Loading

Niladri24dutta commented Oct 2, 2019

jeromesimeon commented Oct 3, 2019

mttrbrts commented Oct 3, 2019

jeromesimeon commented Oct 3, 2019

jeromesimeon commented Oct 3, 2019 • edited Loading

Niladri24dutta commented Oct 3, 2019

jeromesimeon commented Oct 3, 2019

Niladri24dutta commented Oct 4, 2019

jeromesimeon commented Oct 4, 2019 • edited Loading

Niladri24dutta commented Oct 4, 2019 • edited Loading

jeromesimeon commented Oct 2, 2019 •

edited

Loading

jeromesimeon commented Oct 3, 2019 •

edited

Loading

jeromesimeon commented Oct 4, 2019 •

edited

Loading

Niladri24dutta commented Oct 4, 2019 •

edited

Loading