Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop support for wildcard imports #458

Closed
dselman opened this issue Jul 25, 2022 · 1 comment Β· Fixed by #498
Closed

Drop support for wildcard imports #458

dselman opened this issue Jul 25, 2022 · 1 comment Β· Fixed by #498

Comments

@dselman
Copy link
Contributor

dselman commented Jul 25, 2022

Feature Request πŸ›οΈ

Concerto metamodel currently allows the user to import all types from a namespace:

import org.acme.*

Use Case

Wild card imports are risky as a new type can be introduced in the imported namespace that has a name collision with a type in the importing namespace.

Possible Solution

Drop support for wildcard imports.

Context

Makes it difficult to build a static dependency graph of namespaces and imported types.

Detailed Description

Efficient import resolution, at scale.

@sstone1
Copy link
Contributor

sstone1 commented Jul 25, 2022

@dselman could we use the versionedNamespacesStrict: true flag for this, so that when versioning is enabled then you cannot use wildcard imports? Then we could drop it altogether when we make versionedNamespacesStrict: true the default, which I would think might be a Concerto v3 item.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment