Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JSONSchemaVisitor fails with some models #206

Closed
dselman opened this issue Sep 21, 2020 · 1 comment
Closed

JSONSchemaVisitor fails with some models #206

dselman opened this issue Sep 21, 2020 · 1 comment
Assignees
@dselman
Labels
Type: Bug 🐛 Something isn't working

Comments

@dselman
Copy link
Contributor

dselman commented Sep 21, 2020

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Checkout: https://github.com/accordproject/models
  2. npm i
  3. node. build.js
  4. See errors generating the schema for some models. E.g.
Generating JsonSchema for /Users/dselman/dev/models/build/ergo/monitor: Maximum call stack size exceeded

Expected behavior

Should not fail to generate JSON Schema for valid models.
@dselman dselman self-assigned this Sep 21, 2020
@dselman dselman added the Type: Bug 🐛 Something isn't working label Sep 21, 2020
@dselman
Copy link
Contributor Author

dselman commented Sep 23, 2020

Addressed in: a95e1fd

@dselman dselman closed this as completed Sep 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dselman dselman

Labels
Type: Bug 🐛 Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dselman