Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support variant serialization/deserialization for the latest Ergo runtime #110

Closed
jeromesimeon opened this issue Oct 6, 2019 · 2 comments
Assignees

Comments

@jeromesimeon
Copy link
Member

Is your feature request related to a problem? Please describe.
Ergo 0.20.* relies on a few changes to the Concerto serialisation that have to be consistent with the Ergo JavaScript run time. The changes include:

  • Alternative representation for enums consistent with the new typed enums in Ergo
  • Alternative representation for Integer and Long values to ensure proper printing in toString and in the templates support
  • Additional option for serialisation of relationships

This should be controlled by a proper option on the serialiser and ensure backward compatibility when that option is turned off (which should be the default).

Describe the solution you'd like
Fold changes for that serialization from the Ergo 0.20 branch into Concerto, which avoid much code duplication and provides for better and more systematic testing.

Additional context
This is part of a core refactoring for the 0.20 release. This change will also facilitate review and discussion for improvements in future releases.

@jeromesimeon
Copy link
Member Author

Initial code for this can be found in accordproject/ergo@500b0f7

PR which supports this new option and passes all the tests is available at:
#111

@jeromesimeon
Copy link
Member Author

Fixed in #111

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant