feat(map): Extend supported Key Types for C# codegen #71
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
mttrbrts
reviewed
Nov 14, 2023
| @@ -5980,7 +5980,7 @@ public abstract class Person : Participant { | |||
| public string ssn { get; set; } | |||
| public float height { get; set; } | |||
| public System.DateTime dob { get; set; } | |||
| public Dictionary<string, KinTelephone> nextOfKin { get; set; } | |||
| public Dictionary<string, System.DateTime> nextOfKin { get; set; } | |||
| } | |||
There was a problem hiding this comment.
These types seem to have got more general. Is this expected?
There was a problem hiding this comment.
Yes, the underlying Primitive of a Scalar should be printed, in place of its alias name
There was a problem hiding this comment.
Beware the logic that handles UUID. Did you test with a map that has a UUID as a key or value? It looks like the code generator doesn't unbox those.
There was a problem hiding this comment.
@dselman logic added to handle concerto.scalar.UUID for k & v
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
Signed-off-by: Jonathan Casey <[email protected]>
dselman
approved these changes
Jan 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Author Checklist
--signoffoption of git commit.mainfromfork:branchname